Skip to content

KAFKA-14596: Move TopicCommand to tools #13201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mimaison merged 11 commits into from
Oct 17, 2023
Merged

KAFKA-14596: Move TopicCommand to tools #13201

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
521cbed
KAFKA-14596: Move TopicCommand to tools
OmniaGM Feb 6, 2023
06cb3d2
Address fvaleri's feedback
OmniaGM Aug 17, 2023
590fa47
fix test
OmniaGM Aug 18, 2023
0574774
Fix format
OmniaGM Sep 11, 2023
5b86ae0
Fix invalidOptions to retains order of insertions
OmniaGM Sep 13, 2023
f764089
reduce dependencies
OmniaGM Sep 15, 2023
11f6a3e
fix compilation
OmniaGM Oct 9, 2023
1055c5b
fix `[this-escape]` warnings
OmniaGM Oct 10, 2023
d460fbd
address Mickael's feedback
OmniaGM Oct 13, 2023
6259143
address Mickael's feedback
OmniaGM Oct 16, 2023
30864b5
wait for topic creation
OmniaGM Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/kafka-topics.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@
# See the License for the specific language governing permissions and
# limitations under the License.

exec $(dirname $0)/kafka-run-class.sh kafka.admin.TopicCommand "$@"
exec $(dirname $0)/kafka-run-class.sh org.apache.kafka.tools.TopicCommand "$@"
2 changes: 1 addition & 1 deletion bin/windows/kafka-topics.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ rem WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
rem See the License for the specific language governing permissions and
rem limitations under the License.

"%~dp0kafka-run-class.bat" kafka.admin.TopicCommand %*
"%~dp0kafka-run-class.bat" org.apache.kafka.tools.TopicCommand %*
5 changes: 1 addition & 4 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1884,17 +1884,14 @@ project(':tools:tools-api') {

project(':tools') {
archivesBaseName = "kafka-tools"

dependencies {
implementation project(':clients')
implementation project(':storage')
implementation project(':server-common')
implementation project(':connect:api')
implementation project(':connect:runtime')
implementation project(':log4j-appender')
implementation project(':tools:tools-api')
implementation libs.argparse4j
implementation libs.jacksonDatabind
implementation libs.jacksonJDK8Datatypes
implementation libs.slf4jApi
implementation libs.log4j
implementation libs.joptSimple
Expand Down
3 changes: 3 additions & 0 deletions checkstyle/import-control.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,9 @@
<subpackage name="tools">
<allow pkg="org.apache.kafka.common"/>
<allow pkg="org.apache.kafka.server.util" />
<allow pkg="kafka.admin" />
<allow pkg="kafka.server" />
<allow pkg="org.apache.kafka.storage.internals" />
<allow pkg="org.apache.kafka.server.common" />
<allow pkg="org.apache.kafka.clients" />
<allow pkg="org.apache.kafka.clients.admin" />
Expand Down
Loading