Skip to content

MINOR: Various cleanups in common utils#13174

Merged
mimaison merged 1 commit into
apache:trunkfrom
mimaison:common-utils
Feb 27, 2023
Merged

MINOR: Various cleanups in common utils#13174
mimaison merged 1 commit into
apache:trunkfrom
mimaison:common-utils

Conversation

@mimaison

Copy link
Copy Markdown
Member
  • Remove unused methods
  • Cleanup syntax

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

- Remove unused methods
- Cleanup syntax

@Override
public final boolean hasNext() {
public boolean hasNext() {

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class is final

@clolov clolov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and straightforward :)

@jlprat jlprat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mimaison!
Changes look straight-forward.

@mimaison
mimaison merged commit 461c5cf into apache:trunk Feb 27, 2023
@mimaison
mimaison deleted the common-utils branch February 27, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants