Skip to content

MINOR: Remove duplicate empty string check#13145

Merged
mimaison merged 1 commit into
apache:trunkfrom
mimaison:remove-empty-check
Feb 27, 2023
Merged

MINOR: Remove duplicate empty string check#13145
mimaison merged 1 commit into
apache:trunkfrom
mimaison:remove-empty-check

Conversation

@mimaison

Copy link
Copy Markdown
Member

Values.parseString() handles empty strings and returns the same SchemaAndValue [0] so we don't need to do the check in toConnectHeader().

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@clolov clolov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Short and sweet :)

@mimaison

Copy link
Copy Markdown
Member Author

@C0urante can you take a look? Thanks

@C0urante C0urante left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clolov took the words right out of my mouth :)

@mimaison
mimaison merged commit 8d7d563 into apache:trunk Feb 27, 2023
@mimaison
mimaison deleted the remove-empty-check branch February 27, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants