Skip to content
Merged
Show file tree
Hide file tree
Changes from 33 commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
a059d85
Basic event handler definition
Sep 19, 2022
008ca46
Define EventHandler interface
Sep 19, 2022
5bb3362
lint error
Sep 19, 2022
6551807
moving packages
Sep 19, 2022
86191c2
reduce the scope
Sep 20, 2022
c0ef143
PR comments for naming and documentation
Sep 21, 2022
564660f
Documentation on the beahvior
Sep 21, 2022
4f0a15e
Add isEmpty and remove excessive public
Sep 21, 2022
4828f71
Remove unused import
Sep 21, 2022
779c00c
Handle capacity limitation
Sep 21, 2022
b18098d
clean up a comment
Sep 22, 2022
ce00e48
A stubbed event handler to demonstrate the usage.
Sep 26, 2022
30e059b
typo
Sep 26, 2022
0e5a6dd
Revert "typo"
Sep 27, 2022
1ed6836
Revert "A stubbed event handler to demonstrate the usage."
Sep 27, 2022
bbabb93
Prototyping
Sep 27, 2022
e081c5f
clean up and documentation
Sep 27, 2022
d5c8009
background thread
Sep 19, 2022
684a0a1
Testing, background thread impl.
Sep 27, 2022
c80059a
renaming for clarity
Sep 30, 2022
480eb9a
fixes
Sep 30, 2022
422eed4
Refactor the background to make clear it is a network io thread
Oct 1, 2022
359eda9
wip
Oct 3, 2022
ebdc0d2
delete file
Oct 3, 2022
ca1d1c0
tests
Oct 3, 2022
6f1f8e5
extra space
Oct 3, 2022
14d9f52
spaces
Oct 3, 2022
5855d74
tests seem flakey
Oct 3, 2022
0cbf1f9
PR comments
Oct 3, 2022
6cfa912
cleaned up PR
Oct 3, 2022
c3d3d03
exception handling
Oct 4, 2022
7669b0a
clean up unused import
Oct 4, 2022
2d66bda
More documentation and better exception handling
Oct 6, 2022
3a52b13
refactor based on PR comment
Oct 10, 2022
45c55f9
Move network client construction to the handler
Oct 11, 2022
8f2c870
clean up
Oct 11, 2022
a343d2d
wakeup logic
Oct 12, 2022
7f3424d
documentation
Oct 12, 2022
d0e8f20
swallow interrupt exception
Oct 12, 2022
5440664
test swallowed exception
Oct 12, 2022
498e06b
remove the test for testing
Oct 12, 2022
f3158aa
wakeup exception test
Oct 12, 2022
fbb59e8
refactor based on PR comment
Oct 18, 2022
bec9391
debug message
Oct 18, 2022
f10d530
apply AK code conventions
vvcephei Oct 19, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.kafka.clients.consumer.internals;

import java.io.Closeable;

/**
* Background thread runnable that handles network IO such as fetching and committing.
*/
public interface BackgroundThreadRunnable extends Runnable, Closeable {
Comment thread
philipnee marked this conversation as resolved.
Outdated
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,284 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.kafka.clients.consumer.internals;

import org.apache.kafka.clients.ApiVersions;
import org.apache.kafka.clients.ClientUtils;
import org.apache.kafka.clients.CommonClientConfigs;
import org.apache.kafka.clients.NetworkClient;
import org.apache.kafka.clients.consumer.ConsumerConfig;
import org.apache.kafka.clients.consumer.internals.events.ApplicationEvent;
import org.apache.kafka.clients.consumer.internals.events.BackgroundEvent;
import org.apache.kafka.clients.consumer.internals.events.NoopApplicationEvent;
import org.apache.kafka.common.KafkaException;
import org.apache.kafka.common.errors.InterruptException;
import org.apache.kafka.common.internals.ClusterResourceListeners;
import org.apache.kafka.common.metrics.Metrics;
import org.apache.kafka.common.metrics.Sensor;
import org.apache.kafka.common.network.ChannelBuilder;
import org.apache.kafka.common.network.Selector;
import org.apache.kafka.common.utils.LogContext;
import org.apache.kafka.common.utils.Time;
import org.apache.kafka.common.utils.Utils;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import java.net.InetSocketAddress;
import java.util.List;
import java.util.Optional;
import java.util.concurrent.BlockingQueue;
import java.util.concurrent.atomic.AtomicReference;

/**
* Background thread runnable that consumes {@code ApplicationEvent} and
* produces {@code BackgroundEvent}. It uses an event loop to consume and
* produce events, and poll the network client to handle network IO.
*
* It holds a reference to the {@link SubscriptionState}, which is
* initialized by the polling thread.
*/
public class DefaultBackgroundThreadRunnable implements BackgroundThreadRunnable {
Comment thread
philipnee marked this conversation as resolved.
Outdated
private static final String METRIC_GRP_PREFIX = "consumer";

private final Time time;
private final Logger log;
private final BlockingQueue<ApplicationEvent> applicationEventQueue;
private final BlockingQueue<BackgroundEvent> backgroundEventQueue;
private final ConsumerNetworkClient networkClient;
private final SubscriptionState subscriptions;
private final ConsumerMetadata metadata;
private final Metrics metrics;
private final ConsumerConfig config;

private String clientId;
private long retryBackoffMs;
private int heartbeatIntervalMs;
Comment thread
philipnee marked this conversation as resolved.
Outdated
private boolean running;
private Optional<ApplicationEvent> inflightEvent = Optional.empty();
private AtomicReference<Optional<RuntimeException>> exception =
new AtomicReference<>(Optional.empty());

public DefaultBackgroundThreadRunnable(ConsumerConfig config,
LogContext logContext,
BlockingQueue<ApplicationEvent> applicationEventQueue,
BlockingQueue<BackgroundEvent> backgroundEventQueue,
SubscriptionState subscriptions,
ApiVersions apiVersions,
Metrics metrics,
ClusterResourceListeners clusterResourceListeners,
Sensor fetcherThrottleTimeSensor) {
this(Time.SYSTEM,
config,
logContext,
applicationEventQueue,
backgroundEventQueue,
subscriptions,
apiVersions,
metrics,
clusterResourceListeners,
fetcherThrottleTimeSensor);
}

public DefaultBackgroundThreadRunnable(Time time,
Comment thread
philipnee marked this conversation as resolved.
Outdated
ConsumerConfig config,
LogContext logContext,
BlockingQueue<ApplicationEvent> applicationEventQueue,
BlockingQueue<BackgroundEvent> backgroundEventQueue,
SubscriptionState subscriptions,
ApiVersions apiVersions,
Metrics metrics,
ClusterResourceListeners clusterResourceListeners,
Sensor fetcherThrottleTimeSensor) {
try {
this.time = time;
this.log = logContext.logger(DefaultBackgroundThreadRunnable.class);
this.applicationEventQueue = applicationEventQueue;
this.backgroundEventQueue = backgroundEventQueue;
this.config = config;
setConfig();
this.inflightEvent = Optional.empty();
// subscriptionState is initialized in the polling thread
this.subscriptions = subscriptions;
this.metrics = metrics;
this.metadata = bootstrapMetadata(clusterResourceListeners, logContext);
ChannelBuilder channelBuilder = ClientUtils.createChannelBuilder(config, time, logContext);
Selector selector = new Selector(config.getLong(
ConsumerConfig.CONNECTIONS_MAX_IDLE_MS_CONFIG),
metrics,
time,
METRIC_GRP_PREFIX,
channelBuilder,
logContext);
NetworkClient netClient = new NetworkClient(
selector,
metadata,
clientId,
100, // a fixed large enough value will suffice for max
// in-flight requests
config.getLong(ConsumerConfig.RECONNECT_BACKOFF_MS_CONFIG),
config.getLong(ConsumerConfig.RECONNECT_BACKOFF_MAX_MS_CONFIG),
config.getInt(ConsumerConfig.SEND_BUFFER_CONFIG),
config.getInt(ConsumerConfig.RECEIVE_BUFFER_CONFIG),
config.getInt(ConsumerConfig.REQUEST_TIMEOUT_MS_CONFIG),
config.getLong(ConsumerConfig.SOCKET_CONNECTION_SETUP_TIMEOUT_MS_CONFIG),
config.getLong(ConsumerConfig.SOCKET_CONNECTION_SETUP_TIMEOUT_MAX_MS_CONFIG),
time,
true,
apiVersions,
fetcherThrottleTimeSensor,
logContext);
this.networkClient = new ConsumerNetworkClient(
logContext,
netClient,
metadata,
time,
retryBackoffMs,
config.getInt(ConsumerConfig.REQUEST_TIMEOUT_MS_CONFIG),
heartbeatIntervalMs);
this.running = true;
} catch (Exception e) {
// now propagate the exception
close();
throw new KafkaException("Failed to construct background processor", e);
}
}

// VisibleForTesting
DefaultBackgroundThreadRunnable(Time time,
Comment thread
philipnee marked this conversation as resolved.
Outdated
ConsumerConfig config,
BlockingQueue<ApplicationEvent> applicationEventQueue,
BlockingQueue<BackgroundEvent> backgroundEventQueue,
SubscriptionState subscriptions,
ConsumerMetadata metadata,
ConsumerNetworkClient client) {
this.time = time;
this.config = config;
setConfig();
this.log = LoggerFactory.getLogger(getClass());
this.applicationEventQueue = applicationEventQueue;
this.backgroundEventQueue = backgroundEventQueue;
this.subscriptions = subscriptions;
this.metadata = metadata;
this.networkClient = client;
this.metrics = new Metrics();
this.running = true;
}

private void setConfig() {
Comment thread
philipnee marked this conversation as resolved.
Outdated
this.retryBackoffMs = this.config.getLong(ConsumerConfig.RETRY_BACKOFF_MS_CONFIG);
this.clientId = config.getString(CommonClientConfigs.CLIENT_ID_CONFIG);
this.heartbeatIntervalMs = config.getInt(ConsumerConfig.HEARTBEAT_INTERVAL_MS_CONFIG);
}

@Override
public void run() {
try {
log.debug("{} started", getClass());
while (running) {
runOnce();
time.sleep(retryBackoffMs);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of setting a sleep here, I think it's better to have a waitOnEmptyInputQueue function with a condition. Where the caller thread would notify when enqueuing a new item.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guozhangwang - I thought we wanted to maintain an active loop because we want to keep sending fetches and rebalance requests despite an empty ApplicationQueue.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think so -- please see my other comment below: #12672 (comment). But I still feel that instead of having a sleep for each iteration, we should just consider poll on the network client with a timeout, i.e. supposing our loop would look like:

  1. try to get some event from the queue, if yes, then handle it and potentially send the corresponding request;
  2. if the queue is empty, then try to send a fetch request.
  3. poll the network client in order to receive any responses ready-to-read on the socket.

Then our logic could be: if there's no new actions taken at step 1/2), i.e. we do not have any new items from the queue, and we do not yet need to send any new fetch/rebalance-related requests, then at step 3) we poll for a bit longer time until being notified by the caller that there's new items in the queue; otherwise, at step 3) we just poll without timeout and then immediately move on to the next iteration.

}
} catch (InterruptException e) {
log.error("The background thread has been interrupted");

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we want to retain interrupt exceptions as well, instead of just ignoring it and continue the next iteration?

this.exception.set(Optional.of(new RuntimeException(e)));
} catch (Throwable t) {
log.error("The background failed due to unexpected error", t);
if (t instanceof RuntimeException)
this.exception.set(Optional.of((RuntimeException) t));
else
this.exception.set(Optional.of(new RuntimeException(t)));
} finally {
close();
log.debug("{} closed", getClass());
}
}

/**
* Process event from a single poll
*/
void runOnce() {
this.inflightEvent = maybePollEvent();
log.debug("processing applicatoin event: {}", this.inflightEvent);
if (this.inflightEvent.isPresent() && maybeConsumeInflightEvent(this.inflightEvent.get())) {
// clear inflight event upon successful consumption
this.inflightEvent = Optional.empty();
}
networkClient.pollNoWakeup();
}

public Optional<ApplicationEvent> maybePollEvent() {
if (this.inflightEvent.isPresent() || this.applicationEventQueue.isEmpty()) {
return this.inflightEvent;
}
return Optional.ofNullable(this.applicationEventQueue.poll());
Comment thread
philipnee marked this conversation as resolved.
Outdated
}

/**
* ApplicationEvent are consumed here.
* @param event an {@link ApplicationEvent}
* @return true when successfully consumed the event.
*/
public boolean maybeConsumeInflightEvent(ApplicationEvent event) {
log.debug("try consuming event: {}", Optional.ofNullable(event));
switch (event.type) {
case NOOP:
process((NoopApplicationEvent) event);
return true;
default:
inflightEvent = Optional.empty();
Comment thread
philipnee marked this conversation as resolved.
Outdated
log.warn("unsupported event type: {}", event.type);
return true;
}
}

/**
* Processes {@link NoopApplicationEvent} and equeue a {@link NoopBackgroundEvent}. This is intentionally left here
* for demonstration purpose.
* @param event a {@link NoopApplicationEvent}
*/
private void process(NoopApplicationEvent event) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like what a mock client needs to do, why we need to add it to the default implementation? Or are we going to remove it in this class later?

backgroundEventQueue.add(new NoopBackgroundEvent(event.message));
}

public boolean isRunning() {
return this.running;
}

public Optional<RuntimeException> exception() {
Comment thread
philipnee marked this conversation as resolved.
Outdated
return this.exception.get();
}

@Override
public void close() {
this.running = false;
Utils.closeQuietly(networkClient, "consumer network client");
Comment thread
philipnee marked this conversation as resolved.
Outdated
Utils.closeQuietly(metadata, "consumer network client");
}

private ConsumerMetadata bootstrapMetadata(ClusterResourceListeners clusterResourceListeners, LogContext logContext) {
ConsumerMetadata metadata = new ConsumerMetadata(retryBackoffMs,
config.getLong(ConsumerConfig.METADATA_MAX_AGE_CONFIG),
!config.getBoolean(ConsumerConfig.EXCLUDE_INTERNAL_TOPICS_CONFIG),
config.getBoolean(ConsumerConfig.ALLOW_AUTO_CREATE_TOPICS_CONFIG),
this.subscriptions,
logContext, clusterResourceListeners);
List<InetSocketAddress> addresses = ClientUtils.parseAndValidateAddresses(
config.getList(ConsumerConfig.BOOTSTRAP_SERVERS_CONFIG), config.getString(ConsumerConfig.CLIENT_DNS_LOOKUP_CONFIG));
metadata.bootstrap(addresses);
return metadata;
}
}
Loading