Skip to content

MINOR: Remove ARM/PowerPC builds from Jenkinsfile - #12380

Merged
cmccabe merged 2 commits into
apache:trunkfrom
hachikuji:remove-agent-checks-jenkinsfile
Aug 3, 2022
Merged

MINOR: Remove ARM/PowerPC builds from Jenkinsfile#12380
cmccabe merged 2 commits into
apache:trunkfrom
hachikuji:remove-agent-checks-jenkinsfile

Conversation

@hachikuji

Copy link
Copy Markdown
Contributor

We see the ARM agent check timing out frequently. I think the 5 minute timeout might be too aggressive. I think the original intent of this check was to prevent one of these agent check timeouts from propagating to the top level, but that never really worked. So perhaps we don't need these.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@showuon

showuon commented Jul 6, 2022

Copy link
Copy Markdown
Member

The ARM build is still failing. I've rebuilt it and failed, too.
https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-12380/2/pipeline/76

I can also take a look when I have time. Thanks.

@mumrah

mumrah commented Jul 6, 2022

Copy link
Copy Markdown
Member

We can probably do without these agent checks. The idea behind them was to fail-fast when the node provider wasn't available (rather than waiting for the 2hr timeout). But, the end result is pretty much the same (aborted build status).

I wonder if we can set up a different Jenkins job that runs on trunk only for ARM and PPC. I doubt we have gained much from running these builds on each PR. Seems they mainly add noise to our build status.

@ijuma

ijuma commented Jul 8, 2022

Copy link
Copy Markdown
Member

+1 for removing these builds from PRs. Generally, we should only include widely used platforms where we also have stable build machines.

@dajac

dajac commented Jul 8, 2022

Copy link
Copy Markdown
Member

Using different Jenkins jobs that runs on trunk seems to be a good tradeoff.

@hachikuji

Copy link
Copy Markdown
Contributor Author

@showuon @ijuma @mumrah @dajac Thanks. I've removed these builds from the Jenkinsfile. I am not sure I know how to run them only against trunk. If one of you knows how to do that, let me know or we can consider doing it separately.

@hachikuji hachikuji changed the title MINOR: Get rid of agent checks in Jenkinsfile MINOR: Remove ARM/PowerPC builds from Jenkinsfile Jul 9, 2022
@dajac

dajac commented Jul 10, 2022

Copy link
Copy Markdown
Member

I suppose that we could use the “when” clause like here:

when {

We can definitely do this separately.

@cmccabe

cmccabe commented Aug 3, 2022

Copy link
Copy Markdown
Contributor

Yeah, these builds are out of control, failing all the time. It's probably more appropriate to make these nightly builds anyway. We can discuss this once we've stabilized the build.

@cmccabe cmccabe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmccabe
cmccabe merged commit 64c72c2 into apache:trunk Aug 3, 2022
ijuma added a commit to confluentinc/kafka that referenced this pull request Aug 5, 2022
…(5 August 2022)

Version related conflicts:
* Jenkinsfile
* gradle.properties
* streams/quickstart/java/pom.xml
* streams/quickstart/java/src/main/resources/archetype-resources/pom.xml
* streams/quickstart/pom.xml
* tests/kafkatest/__init__.py
* tests/kafkatest/version.py

* commit 'add7cd85baa61cd0e1430': (66 commits)
KAFKA-14136 Generate ConfigRecord for brokers even if the value is
unchanged (apache#12483)
  HOTFIX / KAFKA-14130: Reduce RackAwarenesssTest to unit Test (apache#12476)
  MINOR: Remove ARM/PowerPC builds from Jenkinsfile (apache#12380)
  KAFKA-14111 Fix sensitive dynamic broker configs in KRaft (apache#12455)
  KAFKA-13877: Fix flakiness in RackAwarenessIntegrationTest (apache#12468)
KAFKA-14129: KRaft must check manual assignments for createTopics are
contiguous (apache#12467)
KAFKA-13546: Do not fail connector validation if default topic
creation group is explicitly specified (apache#11615)
KAFKA-14122: Fix flaky test
DynamicBrokerReconfigurationTest#testKeyStoreAlter (apache#12452)
  MINOR; Use right enum value for broker registration change (apache#12236)
  MINOR; Synchronize access to snapshots' TreeMap (apache#12464)
  MINOR; Bump trunk to 3.4.0-SNAPSHOT (apache#12463)
  MINOR: Stop logging 404s at ERROR level in Connect
KAFKA-14095: Improve handling of sync offset failures in MirrorMaker
(apache#12432)
  Minor: enable index for emit final sliding window (apache#12461)
  MINOR: convert some more junit tests to support KRaft (apache#12456)
  KAFKA-14108: Ensure both JUnit 4 and JUnit 5 tests run (apache#12441)
  MINOR: Remove code of removed metric (apache#12453)
MINOR: Update comment on verifyTaskGenerationAndOwnership method in
DistributedHerder
KAFKA-14012: Add warning to closeQuietly documentation about method
references of null objects (apache#12321)
  MINOR: Fix static mock usage in ThreadMetricsTest (apache#12454)
  ...
mumrah pushed a commit that referenced this pull request Sep 23, 2022
Reviewers: Colin P. McCabe <cmccabe@apache.org>, Ismael Juma <ismael@juma.me.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants