Skip to content

KAFKA-14012: Add warning to closeQuietly documentation about method references of null objects #12321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
C0urante merged 5 commits into from
Jul 28, 2022
Merged

KAFKA-14012: Add warning to closeQuietly documentation about method references of null objects #12321

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3972e76
KAFKA-14012: Adding null checks for cases when closeQuietly was being…
Jun 21, 2022
cee3c31
Removing null check for configLog and task and added not null for off…
Jun 21, 2022
e7c394a
Review comments addressed
Jun 22, 2022
6c244fb
Adding comments to javadocs of closeQuietly and closeAllQuietly
Jun 26, 2022
fd8eca7
Updating javadocs based on suggestions from review comments
Jul 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractWorkerSourceTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ public void removeMetrics() {

@Override
protected void close() {
if (started) {
if (started && task != null) {
Utils.closeQuietly(task::stop, "source task");
}

Expand All @@ -310,7 +310,9 @@ protected void close() {
Utils.closeQuietly(transformationChain, "transformation chain");
Utils.closeQuietly(retryWithToleranceOperator, "retry operator");
Utils.closeQuietly(offsetReader, "offset reader");
Utils.closeQuietly(offsetStore::stop, "offset backing store");
if (offsetReader != null) {
Utils.closeQuietly(offsetStore::stop, "offset backing store");
}
}

private void closeProducer(Duration duration) {
Expand Down
5 changes: 4 additions & 1 deletion connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,10 @@ public void stop() {

relinquishWritePrivileges();
Utils.closeQuietly(ownTopicAdmin, "admin for config topic");
Utils.closeQuietly(configLog::stop, "KafkaBasedLog for config topic");

if (configLog != null) {
Utils.closeQuietly(configLog::stop, "KafkaBasedLog for config topic");
}

log.info("Closed KafkaConfigBackingStore");
}
Expand Down