-
Notifications
You must be signed in to change notification settings - Fork 15.4k
MINOR: add note on IDEMPOTENT_WRITE ACL to 3.2.0 notable changes #12260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ijuma
merged 10 commits into
apache:trunk
from
d-t-w:add-idempotence-acl-notable-changes
Aug 13, 2022
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
935b4b5
MINOR: add note on IDEMPOTENT_WRITE ACL to 3.2.0 notable changes
d-t-w 5c1de71
Include idempotency note in 3.0.1 and 3.1.1 notable changes documenta…
d-t-w 63cd346
rm ul from idempotence note
d-t-w 1c97f08
Tweak
ijuma 04c3ed7
More tweaks
ijuma b03c80b
More tweaks
ijuma e585112
Add missing space
ijuma 3efbf92
Merge branch 'trunk' into add-idempotence-acl-notable-changes
ijuma 6a0fb02
Add missing space
ijuma a03ee63
Fix typo
ijuma File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say something like: Please read the relevant KIP section for the compatibility implications - a noteworthy item worth highlighting is...
Also, we should use the same approach for this and other lines. It's unclear to me why we added a
ulhere, but not in the other case. I'd probably include this paragraph in the previousliThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I was unclear here. I clarified in #12260 (comment)