Skip to content

KAFKA-13598: set log4j appender to default acks #11767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vvcephei wants to merge 1 commit into from
Closed

KAFKA-13598: set log4j appender to default acks #11767

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions log4j-appender/src/main/java/org/apache/kafka/log4jappender/KafkaLog4jAppender.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,9 @@ public class KafkaLog4jAppender extends AppenderSkeleton {
private String kerb5ConfPath;
private Integer maxBlockMs;
private String sslEngineFactoryClass;
private Integer requiredNumAcks;

private int retries = Integer.MAX_VALUE;
private int requiredNumAcks = 1;
private int deliveryTimeoutMs = 120000;
private int lingerMs = 0;
private int batchSize = 16384;
Expand Down Expand Up @@ -285,7 +285,9 @@ public void activateOptions() {
if (compressionType != null)
props.put(COMPRESSION_TYPE_CONFIG, compressionType);

props.put(ACKS_CONFIG, Integer.toString(requiredNumAcks));
if (requiredNumAcks != null)
props.put(ACKS_CONFIG, Integer.toString(requiredNumAcks));

props.put(RETRIES_CONFIG, retries);
props.put(DELIVERY_TIMEOUT_MS_CONFIG, deliveryTimeoutMs);
props.put(LINGER_MS_CONFIG, lingerMs);
Expand Down