MINOR: Clarify producer idempotence default in upgrade docs#11757
Merged
Conversation
hachikuji
reviewed
Feb 14, 2022
| </li> | ||
| </ol> | ||
|
|
||
| <h5><a id="upgrade_300_notable" href="#upgrade_301_notable">Notable changes in 3.1.1</a></h5> |
Contributor
There was a problem hiding this comment.
My html-fu is not particularly strong, but it seems we should change the id and href tags for the new sections?
hachikuji
approved these changes
Feb 14, 2022
hachikuji
left a comment
hachikuji
left a comment
Contributor
There was a problem hiding this comment.
Thanks, LGTM. You might need to do some fixing up when you merge to the older branches, but I expect you already knew that.
Member
Author
|
@hachikuji Thanks. Yes, I intend to fix those two branches so that they match what we have here excluding the 3.2 section. |
Member
Author
|
Btw, I made these changes because Spark has upgraded to 3.1.0 and there was some confusion regarding the compatibility implications of the upgrade. |
ijuma
added a commit
that referenced
this pull request
Feb 14, 2022
* Mention `acks=1` to `acks=all` change in 3.0.0 upgrade docs * Have a separate section for 3.0.1 and 3.1.1 as some may skip the 3.0.0/3.1.0 section when upgrading to a bug fix. * Move the 3.0.0 note to the top since it's more impactful than the other changes. Reviewers: Jason Gustafson <jason@confluent.io>
ijuma
added a commit
that referenced
this pull request
Feb 14, 2022
* Mention `acks=1` to `acks=all` change in 3.0.0 upgrade docs * Have a separate section for 3.0.1 and 3.1.1 as some may skip the 3.0.0/3.1.0 section when upgrading to a bug fix. * Move the 3.0.0 note to the top since it's more impactful than the other changes. Reviewers: Jason Gustafson <jason@confluent.io>
Member
|
Thanks for the clarification! LGTM! |
rajinisivaram
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Mar 3, 2022
…1757) * Mention `acks=1` to `acks=all` change in 3.0.0 upgrade docs * Have a separate section for 3.0.1 and 3.1.1 as some may skip the 3.0.0/3.1.0 section when upgrading to a bug fix. * Move the 3.0.0 note to the top since it's more impactful than the other changes. Reviewers: Jason Gustafson <jason@confluent.io>
3 tasks
jeffkbkim
pushed a commit
to confluentinc/kafka
that referenced
this pull request
May 12, 2022
…1757) * Mention `acks=1` to `acks=all` change in 3.0.0 upgrade docs * Have a separate section for 3.0.1 and 3.1.1 as some may skip the 3.0.0/3.1.0 section when upgrading to a bug fix. * Move the 3.0.0 note to the top since it's more impactful than the other changes. Reviewers: Jason Gustafson <jason@confluent.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
acks=1toacks=allchange in 3.0.0 upgrade docs3.0.0/3.1.0 section when upgrading to a bug fix.
other changes.
Committer Checklist (excluded from commit message)