Skip to content

KAFKA-13563: clear FindCoordinatorFuture for non consumer group mode #11631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guozhangwang merged 5 commits into from
Feb 6, 2022
Merged

KAFKA-13563: clear FindCoordinatorFuture for non consumer group mode #11631

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9375b67
KAFKA-13563: ensure coordinator ready for each consumer poll, to hand…
showuon Dec 30, 2021
23e5884
Merge branch 'trunk' of https://github.com/apache/kafka into KAFKA-13563
showuon Feb 4, 2022
8e27298
KAFKA-13563: fix broken tests and add tests
showuon Feb 5, 2022
796ba96
KAFKA-13563: add tests
showuon Feb 6, 2022
3384017
Merge branch 'trunk' of https://github.com/apache/kafka into KAFKA-13563
showuon Feb 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,15 +517,13 @@ public boolean poll(Timer timer, boolean waitForJoinGroup) {
}
}
} else {
// For manually assigned partitions, if there are no ready nodes, await metadata.
// For manually assigned partitions, if coordinator is unknown, make sure we lookup one and await metadata.
// If connections to all nodes fail, wakeups triggered while attempting to send fetch
// requests result in polls returning immediately, causing a tight loop of polls. Without
// the wakeup, poll() with no channels would block for the timeout, delaying re-connection.
// awaitMetadataUpdate() initiates new connections with configured backoff and avoids the busy loop.
// When group management is used, metadata wait is already performed for this scenario as
// coordinator is unknown, hence this check is not required.
if (metadata.updateRequested() && !client.hasReadyNodes(timer.currentTimeMs())) {
client.awaitMetadataUpdate(timer);
// awaitMetadataUpdate() in ensureCoordinatorReady initiates new connections with configured backoff and avoids the busy loop.
if (coordinatorUnknown() && !ensureCoordinatorReady(timer)) {
return false;
Comment on lines -520 to +538

@showuon showuon Dec 30, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before the change, we will wait for the metadata update if no nodes available, to avoid busy loop when in non consumer group mode. After the change, we did as the group management did, to call ensureCoordinatorReady when coordinator unknown. And in ensureCoordinatorReady. This way, we can also make sure to handle the FindCoordinatorFuture well (and clear it) inside ensureCoordinatorReady.

@guozhangwang guozhangwang Jan 5, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if this fix is a bit overkill, e.g. for those consumers who do not even set the group ID and do not rely on the coordinator for anything, the coordinatorUnknown() would always return true while ensureCoordinatorReady would send a discover coordinator request with null group id.

}
}

Expand Down