MINOR: MetadataShell should handle ProducerIdsRecord#11603
Merged
Conversation
Member
Author
dengziming
force-pushed
the
add-producer-id
branch
2 times, most recently
from
December 14, 2021 15:28
61478ad to
5b88573
Compare
dengziming
force-pushed
the
add-producer-id
branch
from
December 23, 2021 13:34
5b88573 to
443ae26
Compare
Member
Author
hachikuji
reviewed
Feb 10, 2022
hachikuji
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the patch. Left a couple suggestions for consideration.
dengziming
force-pushed
the
add-producer-id
branch
from
February 10, 2022 03:03
2d65c5a to
aaff953
Compare
mimaison
reviewed
Feb 10, 2022
hachikuji
reviewed
Feb 10, 2022
hachikuji
reviewed
Feb 11, 2022
dengziming
force-pushed
the
add-producer-id
branch
from
February 12, 2022 00:27
25b1959 to
e7c832c
Compare
hachikuji
approved these changes
Feb 12, 2022
hachikuji
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks for the patch!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More detailed description of your change
We store producer IDs in broker snapshots in #11527, I think we could also add the ability to inspect it using MetadataShell.
Summary of testing strategy (including rationale)
I tested this locally:
Committer Checklist (excluded from commit message)