Skip to content

KAFKA-12933: Flaky test ReassignPartitionsIntegrationTest.testReassignmentWithAlterIsrDisabled #11244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ijuma merged 1 commit into from
Aug 23, 2021
Merged

KAFKA-12933: Flaky test ReassignPartitionsIntegrationTest.testReassignmentWithAlterIsrDisabled #11244

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion core/src/test/scala/integration/kafka/admin/ReassignPartitionsIntegrationTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,6 @@ class ReassignPartitionsIntegrationTest extends ZooKeeperTestHarness {
)

val verifyAssignmentResult = runVerifyAssignment(cluster.adminClient, assignment, false)
assertTrue(verifyAssignmentResult.partsOngoing)
assertFalse(verifyAssignmentResult.movesOngoing)
Comment on lines 129 to 130

@showuon showuon Aug 21, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked and confirmed that this change makes sense, because there might not have on-going reassignment at this moment if the reassignment completed before we verify it.

However, in this case, I don't think we verify the moveOngoing makes sense here, either, since it might passed just because the reassignment completed before the verification. I think we can directly remove all these 3 lines and directly wait for the reassignment completion. What do you think?

@splett2 splett2 Aug 22, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verifying moveOngoing here is fine because we don't perform intra-broker replica assignments(alter log dirs) in these tests, so movesOngoing should always be false.


// Wait for the assignment to complete
Expand Down