KAFKA-12904: Corrected the timeout for config validation REST API resource#10834
Merged
Conversation
…ource The constant is specified in milliseconds, and so the MILLISECOND time unit should be used instead of SECONDS.
kkonstantine
approved these changes
Jun 7, 2021
rhauch
added a commit
that referenced
this pull request
Jun 22, 2021
…ource (#10834) The constant is specified in milliseconds, and so the MILLISECOND time unit should be used instead of SECONDS. Author: Randall Hauch <rhauch@gmail.com> Reviewer: Konstantine Karantasis <konstantine@confluent.io>
rhauch
added a commit
that referenced
this pull request
Jun 22, 2021
…ource (#10834) The constant is specified in milliseconds, and so the MILLISECOND time unit should be used instead of SECONDS. Author: Randall Hauch <rhauch@gmail.com> Reviewer: Konstantine Karantasis <konstantine@confluent.io>
rhauch
added a commit
that referenced
this pull request
Jun 22, 2021
…ource (#10834) The constant is specified in milliseconds, and so the MILLISECOND time unit should be used instead of SECONDS. Author: Randall Hauch <rhauch@gmail.com> Reviewer: Konstantine Karantasis <konstantine@confluent.io>
xdgrulez
pushed a commit
to xdgrulez/kafka
that referenced
this pull request
Dec 22, 2021
…ource (apache#10834) The constant is specified in milliseconds, and so the MILLISECOND time unit should be used instead of SECONDS. Author: Randall Hauch <rhauch@gmail.com> Reviewer: Konstantine Karantasis <konstantine@confluent.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The constant is specified in milliseconds, and so the MILLISECOND time unit should be used instead of SECONDS. See #8069/KAFKA-9374.
Inspected other uses of the same constant and other changes in the original PR, and found no other errors. This kind of change is actually difficult to test for, so this relies upon existing unit and integration tests.
Users may run into this whenever validating a connector configuration where the connector implementation takes more than the 90 seconds to actually validate the configuration.
PUT /connector-plugins/(string:name)/config/validateREST requests might not return500 Internal Server Errorand may block (the request thread) for a long period of time.PUT /connector-plugins/(string:name)/config/validateREST requests might not return500 Internal Server Errorif the connector does not complete the validation of a connector configuration within 90 seconds.The user will not see a difference between the behavior before or after this fix if/when the connectors complete validation of connector configurations before 90 seconds, since the method will return those results to the client.
Committer Checklist (excluded from commit message)