Skip to content

Corrected the timeout for config validation REST API resource#10833

Closed
rhauch wants to merge 1 commit into
apache:trunkfrom
rhauch:KAFKA-9374
Closed

Corrected the timeout for config validation REST API resource#10833
rhauch wants to merge 1 commit into
apache:trunkfrom
rhauch:KAFKA-9374

Conversation

@rhauch

@rhauch rhauch commented Jun 7, 2021

Copy link
Copy Markdown
Contributor

The constant is specified in milliseconds, and so the MILLISECOND time unit should be used instead of SECONDS. See #8069.

Inspected other uses of the same constant and other changes in the original PR, and found no other errors. This kind of change is actually difficult to test for, so this relies upon existing unit and integration tests.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

…urce

The constant is specified in milliseconds, and so the MILLISECOND time unit should be used instead of SECONDS.
@rhauch rhauch added the connect label Jun 7, 2021
@rhauch
rhauch requested a review from kkonstantine June 7, 2021 15:42
@rhauch rhauch changed the title KAFKA-9374: Corrected the timeout for config validation REST API resource KAFKA-12904: Corrected the timeout for config validation REST API resource Jun 7, 2021
@rhauch rhauch closed this Jun 7, 2021
@rhauch
rhauch deleted the KAFKA-9374 branch June 7, 2021 15:48
@rhauch

rhauch commented Jun 7, 2021

Copy link
Copy Markdown
Contributor Author

Specified the wrong KAFKA issue in my PR branch.

@rhauch rhauch changed the title KAFKA-12904: Corrected the timeout for config validation REST API resource Corrected the timeout for config validation REST API resource Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant