MINOR: Don't ignore deletion of partition metadata file and log topic id clean-ups#10761
Conversation
|
cc @jolshan |
jolshan
left a comment
jolshan
left a comment
There was a problem hiding this comment.
LGTM. I like that we are preventing direct access to writing the topic ID field.
chia7712
left a comment
chia7712
left a comment
There was a problem hiding this comment.
+1 and one minor comment below.
| try partitionMetadataFile.delete() | ||
| catch { | ||
| case e: IOException => | ||
| error(s"Error while trying to delete partition metadata file ${partitionMetadataFile}", e) |
There was a problem hiding this comment.
Should partitionMetadataFile override toString to offer readable message?
There was a problem hiding this comment.
Ah this is a good point. The toString method could include the file path.
…nups * apache-github/trunk: MINOR: Adjust parameter ordering of `waitForCondition` and `retryOnExceptionWithTimeout` (apache#10759) KAFKA-12796: Removal of deprecated classes under streams-scala (apache#10710) KAFKA-12819: Add assert messages to MirrorMaker tests plus other quality of life improvements (apache#10762) Update implementation.html (apache#10771) MINOR: Log constructor: Flip logical NOT for readability (apache#10756) MINOR: deprecate TaskMetadata constructor and add KIP-740 notes to upgrade guide (apache#10755) MINOR: Log more information when producer snapshot is written (apache#10757) KAFKA-12260: Avoid hitting NPE for partitionsFor (apache#10017) MINOR: add window verification to sliding-window co-group test (apache#10745) KAFKA-12800: Configure generator to fail on trailing JSON tokens (apache#10717)
|
JDK 11 build passed, a few unrelated failures for the other builds:
|
3 participants
Log if deletion fails and don't expose log topic id for mutability outside of
assignTopicId().Also remove an unnecessary parameter in
PartitionTest.Committer Checklist (excluded from commit message)