Skip to content

MINOR: Fix deprecation warnings in SlidingWindowedCogroupedKStreamImplTest #10703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjsax merged 2 commits into from
May 22, 2021
Merged

MINOR: Fix deprecation warnings in SlidingWindowedCogroupedKStreamImplTest #10703

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ac7976
MINOR: Fix deprecations warnings in SlidingWindowedCogroupedKStreamIm…
ijuma May 15, 2021
cbf83b6
Address review feedback
ijuma May 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...a/org/apache/kafka/streams/kstream/internals/SlidingWindowedCogroupedKStreamImplTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ public void slidingWindowAggregateStreamsTest() {
final TestInputTopic<String, String> testInputTopic = driver.createInputTopic(
TOPIC, new StringSerializer(), new StringSerializer());
final TestOutputTopic<Windowed<String>, String> testOutputTopic = driver.createOutputTopic(
OUTPUT, new TimeWindowedDeserializer<>(new StringDeserializer()), new StringDeserializer());
OUTPUT, new TimeWindowedDeserializer<>(new StringDeserializer(), Long.MAX_VALUE), new StringDeserializer());

@mjsax mjsax May 15, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems we setup the window with 500ms:

SlidingWindows.withTimeDifferenceAndGrace(ofMillis(500L),...)

Thus we should pass in the same value instead of MAX_VAVLUE.

We should also change TestRecord<String,String> below to TestRecorded<Windowed<String>,String>

@ijuma ijuma May 16, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed the code to pass 500L, but the TestRecord change causes compilation errors since we explicitly use a nonWindowedRecord:

results.add(nonWindowedRecord);

Can we address that separately? I think we can focus on fixing the deprecation warning in this PR, if that's ok with you.


testInputTopic.pipeInput("k1", "A", 500);
testInputTopic.pipeInput("k2", "A", 500);
Expand Down Expand Up @@ -212,7 +212,7 @@ public void slidingWindowAggregateOverlappingWindowsTest() {
final TestInputTopic<String, String> testInputTopic = driver.createInputTopic(
TOPIC, new StringSerializer(), new StringSerializer());
final TestOutputTopic<Windowed<String>, String> testOutputTopic = driver.createOutputTopic(
OUTPUT, new TimeWindowedDeserializer<>(new StringDeserializer()), new StringDeserializer());
OUTPUT, new TimeWindowedDeserializer<>(new StringDeserializer(), Long.MAX_VALUE), new StringDeserializer());

@mjsax mjsax May 15, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as above


testInputTopic.pipeInput("k1", "A", 500);
testInputTopic.pipeInput("k2", "A", 500);
Expand Down