MINOR: Support ExponentialBackoff without jitter#10455
Merged
Merged
Conversation
mumrah
reviewed
Apr 5, 2021
| double exp = Math.min(attempts, this.expMax); | ||
| double term = initialInterval * Math.pow(multiplier, exp); | ||
| double randomFactor = ThreadLocalRandom.current().nextDouble(1 - jitter, 1 + jitter); | ||
| double randomFactor = jitter < Double.MIN_NORMAL ? 1.0 : |
Member
There was a problem hiding this comment.
I had to look this constant up :)
Can we just make it check if the jitter is equal to zero (or maybe <= zero)? A caller of this method setting jitter to something like 0.5 might be surprised that there is no jitter added.
Contributor
Author
There was a problem hiding this comment.
MIN_NORMAL is 2^-1022, though. So it certainly wouldn't affect someone setting jitter = 0.5.
Member
There was a problem hiding this comment.
Gotcha, I misunderstood the docs and thought it was ~1. Let's keep it as-is
mumrah
approved these changes
Apr 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is useful to allow ExponentialBackoff to be configured to work
without jitter, in order to make unit tests more repeatable.