Skip to content

MINOR: Start the broker-to-controller channel for request forwarding#10340

Merged
mumrah merged 6 commits into
apache:trunkfrom
mumrah:minor-fix-start-forwarding-channel-raft-broker
Mar 18, 2021
Merged

MINOR: Start the broker-to-controller channel for request forwarding#10340
mumrah merged 6 commits into
apache:trunkfrom
mumrah:minor-fix-start-forwarding-channel-raft-broker

Conversation

@mumrah

@mumrah mumrah commented Mar 17, 2021

Copy link
Copy Markdown
Member

Also use different log prefixes for the different channels. Log prefixes now look like:

[BrokerToControllerChannelManager broker=1 name=alterIsr] ...
[BrokerToControllerChannelManager broker=1 name=forwarding] ...
[BrokerToControllerChannelManager broker=1 name=heartbeat] ...

Also use different log prefixes for the different channels
@mumrah
mumrah requested review from abbccdda and hachikuji March 17, 2021 20:34

@hachikuji hachikuji left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

Comment thread core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala Outdated
Comment thread core/src/test/scala/kafka/server/BrokerToControllerRequestThreadTest.scala Outdated
@ijuma

ijuma commented Mar 18, 2021

Copy link
Copy Markdown
Member

Is this a 2.8 blocker?

@mumrah

mumrah commented Mar 18, 2021

Copy link
Copy Markdown
Member Author

@ijuma no this only affects trunk. It looks like the bug was introduced only a few days ago

@ijuma

ijuma commented Mar 18, 2021

Copy link
Copy Markdown
Member

Thanks @mumrah.

@chia7712 chia7712 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mumrah Thanks for this fix!

LGTM

Comment thread core/src/test/scala/kafka/server/BrokerToControllerRequestThreadTest.scala Outdated
@mumrah
mumrah merged commit 94f319d into apache:trunk Mar 18, 2021
ijuma added a commit to confluentinc/kafka that referenced this pull request Mar 19, 2021
Conflicts:
* build.gradle: keep `dependencySubstitution` Confluent addition in
`resolutionStrategy` and take upstream changes.

Commits:
* apache-github/trunk:
  KAFKA-12503: inform threads to resize their cache instead of doing so for them (apache#10356)
  KAFKA-10697: Remove ProduceResponse.responses (apache#10332)
  MINOR: Exclude KIP-500.md from rat check (apache#10354)
  MINOR: Move `configurations.all` to be a child of `allprojects` (apache#10349)
  MINOR: Remove use of `NoSuchElementException` in `KafkaMetadataLog` (apache#10344)
  MINOR: Start the broker-to-controller channel for request forwarding (apache#10340)
  KAFKA-12382: add a README for KIP-500 (apache#10227)
  MINOR: Fix BaseHashTable sizing (apache#10334)
  KAFKA-10357: Add setup method to internal topics (apache#10317)
  MINOR: remove redundant null check when testing specified type (apache#10314)
  KAFKA-12293: Remove JCenter from buildscript and delete buildscript.gradle
  KAFKA-12491: Make rocksdb an `api` dependency for `streams` (apache#10341)
  KAFKA-12454: Add ERROR logging on kafka-log-dirs when given brokerIds do not  exist in current kafka cluster (apache#10304)
  KAFKA-12459; Use property testing library for raft event simulation tests (apache#10323)
  MINOR: fix failing ZooKeeper system tests (apache#10297)
  MINOR: fix client_compatibility_features_test.py (apache#10292)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants