Skip to content

MINOR: output meaningful error message #10268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mimaison merged 1 commit into from
Mar 12, 2021
Merged

MINOR: output meaningful error message #10268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions ...java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,8 +231,8 @@ public void testReplication() throws Exception {
MirrorClient backupClient = new MirrorClient(mm2Config.clientConfig(BACKUP_CLUSTER_ALIAS));

// make sure the topic is auto-created in the other cluster
waitForTopicCreated(primary.kafka(), "backup.test-topic-1");
waitForTopicCreated(backup.kafka(), "primary.test-topic-1");
waitForTopicCreated(primary, "backup.test-topic-1");
waitForTopicCreated(backup, "primary.test-topic-1");
assertEquals(TopicConfig.CLEANUP_POLICY_COMPACT, getTopicConfig(backup.kafka(), "primary.test-topic-1", TopicConfig.CLEANUP_POLICY_CONFIG),
"topic config was not synced");

Expand Down Expand Up @@ -318,8 +318,8 @@ public void testReplication() throws Exception {
backup.kafka().createTopic("test-topic-3", NUM_PARTITIONS);

// make sure the topic is auto-created in the other cluster
waitForTopicCreated(backup.kafka(), "primary.test-topic-2");
waitForTopicCreated(primary.kafka(), "backup.test-topic-3");
waitForTopicCreated(backup, "primary.test-topic-2");
waitForTopicCreated(primary, "backup.test-topic-3");

// only produce messages to the first partition
produceMessages(primary, "test-topic-2", 1);
Expand Down Expand Up @@ -408,8 +408,8 @@ public void testOneWayReplicationWithAutoOffsetSync() throws InterruptedExceptio
waitUntilMirrorMakerIsRunning(backup, CONNECTOR_LIST, mm2Config, PRIMARY_CLUSTER_ALIAS, BACKUP_CLUSTER_ALIAS);

// make sure the topic is created in the other cluster
waitForTopicCreated(primary.kafka(), "backup.test-topic-1");
waitForTopicCreated(backup.kafka(), "primary.test-topic-1");
waitForTopicCreated(primary, "backup.test-topic-1");
waitForTopicCreated(backup, "primary.test-topic-1");
// create a consumer at backup cluster with same consumer group Id to consume 1 topic
Consumer<byte[], byte[]> backupConsumer = backup.kafka().createConsumerAndSubscribeTo(
consumerProps, "primary.test-topic-1");
Expand All @@ -427,7 +427,7 @@ public void testOneWayReplicationWithAutoOffsetSync() throws InterruptedExceptio
// now create a new topic in primary cluster
primary.kafka().createTopic("test-topic-2", NUM_PARTITIONS);
// make sure the topic is created in backup cluster
waitForTopicCreated(backup.kafka(), "primary.test-topic-2");
waitForTopicCreated(backup, "primary.test-topic-2");

// produce some records to the new topic in primary cluster
produceMessages(primary, "test-topic-2");
Expand Down Expand Up @@ -468,17 +468,17 @@ private static void waitUntilMirrorMakerIsRunning(EmbeddedConnectCluster connect
// flaky tests where the connector and tasks didn't start up in time for the tests to be run
for (Class<? extends Connector> connector : connectorClasses) {
connectCluster.assertions().assertConnectorAndAtLeastNumTasksAreRunning(connector.getSimpleName(), 1,
"Connector " + connector.getSimpleName() + " tasks did not start in time on cluster: " + connectCluster);
"Connector " + connector.getSimpleName() + " tasks did not start in time on cluster: " + connectCluster.getName());
}
}

/*
* wait for the topic created on the cluster
*/
private static void waitForTopicCreated(EmbeddedKafkaCluster cluster, String topicName) throws InterruptedException {
try (final Admin adminClient = cluster.createAdminClient()) {
private static void waitForTopicCreated(EmbeddedConnectCluster cluster, String topicName) throws InterruptedException {
try (final Admin adminClient = cluster.kafka().createAdminClient()) {
waitForCondition(() -> adminClient.listTopics().names().get().contains(topicName), TOPIC_SYNC_DURATION_MS,
"Topic: " + topicName + " didn't get created in the cluster"
"Topic: " + topicName + " didn't get created on cluster: " + cluster.getName()
);
}
}
Expand Down
13 changes: 13 additions & 0 deletions .../runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedConnectCluster.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,19 @@ public void startConnect() {
}
}

@Override
public String toString() {
return String.format("EmbeddedConnectCluster(name= %s, numBrokers= %d, numInitialWorkers= %d, workerProps= %s)",
connectClusterName,
numBrokers,
numInitialWorkers,
workerProps);
}

public String getName() {
return connectClusterName;
}

/**
* Get the workers that are up and running.
*
Expand Down