Skip to content

MINOR: add missing docs for record-e2e-latency metrics#10251

Merged
ableegoldman merged 7 commits into
apache:trunkfrom
ableegoldman:DOCS-e2e-latency-metric
Mar 4, 2021
Merged

MINOR: add missing docs for record-e2e-latency metrics#10251
ableegoldman merged 7 commits into
apache:trunkfrom
ableegoldman:DOCS-e2e-latency-metric

Conversation

@ableegoldman

Copy link
Copy Markdown
Member

I missed updating the documentation for these metrics since I didn't notice we had Streams metrics docs outside of the usual Streams docs.

@ableegoldman
ableegoldman requested a review from vvcephei March 3, 2021 04:17
@ableegoldman

Copy link
Copy Markdown
Member Author

call for review @cadonna @vvcephei @guozhangwang -- in theory we should cherrypick this back to 2.8 at least, but I can prepare a separate PR against kafka-site if we don't get this merged in time (not worth blocking 2.8 over obviously)

@ableegoldman
ableegoldman force-pushed the DOCS-e2e-latency-metric branch from f0a6fbc to a4c9250 Compare March 3, 2021 04:24
@ableegoldman
ableegoldman force-pushed the DOCS-e2e-latency-metric branch from a140932 to a95d25e Compare March 3, 2021 04:30
Comment thread docs/ops.html
<td>kafka.streams:type=stream-task-metrics,thread-id=([-.\w]+),task-id=([-.\w]+)</td>
</tr>
<tr>
<td>active-process-ratio</td>

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed that we seem to be missing this task-level metric as well. Might be good to take stock of all the metrics at some point and make sure they're documented clearly, especially since it's easy to miss this doc which is outside of the usual Streams docs

@ableegoldman

Copy link
Copy Markdown
Member Author

Call for review also any of @lct45 @wcarlson5 @swist @mjsax

@wcarlson5 wcarlson5 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ableegoldman

Copy link
Copy Markdown
Member Author

Looks like all three Java builds passed, but some of the other builds failed (with timeout I believe). This is a docs-only change anyway so I think it's safe to merge

@ableegoldman
ableegoldman merged commit 5c22e03 into apache:trunk Mar 4, 2021
ableegoldman added a commit that referenced this pull request Mar 4, 2021
Need to add missing docs for the record-e2e-latency metrics, and new TRACE recording level

Reviewers: Walker Carlson <wcarlson@confluent.io>
@ableegoldman

Copy link
Copy Markdown
Member Author

Merged to trunk and cherrypicked to 2.7 and 2.8 (cc @vvcephei , it's docs only)

ableegoldman added a commit that referenced this pull request Mar 4, 2021
Need to add missing docs for the record-e2e-latency metrics, and new TRACE recording level

Reviewers: Walker Carlson <wcarlson@confluent.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants