Skip to content

MINOR: Remove stack trace of the lock exception in a debug log4j #10231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guozhangwang merged 1 commit into from
Mar 1, 2021
Merged

MINOR: Remove stack trace of the lock exception in a debug log4j #10231

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,14 +426,11 @@ boolean tryToCompleteRestoration(final long now) {
try {
task.initializeIfNeeded();
task.clearTaskTimeout();
} catch (final LockException retriableException) {
} catch (final LockException lockException) {
// it is possible that if there are multiple threads within the instance that one thread
// trying to grab the task from the other, while the other has not released the lock since
// it did not participate in the rebalance. In this case we can just retry in the next iteration
log.debug(
String.format("Could not initialize %s due to the following exception; will retry", task.id()),
retriableException
);
log.debug("Could not initialize task {} since: {}; will retry", task.id(), lockException.getMessage());
allRunning = false;
} catch (final TimeoutException timeoutException) {
task.maybeInitTaskTimeoutOrThrow(now, timeoutException);
Expand Down