Skip to content

MINOR: fix syntax error in upgrade_test.py #10210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmccabe merged 2 commits into from
Feb 25, 2021
Merged

MINOR: fix syntax error in upgrade_test.py #10210

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec383d8
MINOR: fix syntax error in upgrade_test.py
rondagostino Feb 25, 2021
47f4898
fixup
rondagostino Feb 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tests/kafkatest/tests/core/upgrade_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,9 @@ def test_upgrade(self, from_kafka_version, to_message_format_version, compressio
- Finally, validate that every message acked by the producer was consumed by the consumer
"""
self.zk = ZookeeperService(self.test_context, num_nodes=1, version=KafkaVersion(from_kafka_version))
fromKafkaVersion = KafkaVersion(from_kafka_version)
self.kafka = KafkaService(self.test_context, num_nodes=3, zk=self.zk,
version=KafkaVersion(from_kafka_version),
version=fromKafkaVersion,
topics={self.topic: {"partitions": self.partitions,
"replication-factor": self.replication_factor,
'configs': {"min.insync.replicas": 2}}})
Expand Down Expand Up @@ -171,7 +172,7 @@ def test_upgrade(self, from_kafka_version, to_message_format_version, compressio
# after leader change. Tolerate limited data loss for this case to avoid transient test failures.
self.may_truncate_acked_records = False if from_kafka_version >= V_0_11_0_0 else True

new_consumer = from_kafka_version.consumer_supports_bootstrap_server()
new_consumer = fromKafkaVersion.consumer_supports_bootstrap_server()
# TODO - reduce the timeout
self.consumer = ConsoleConsumer(self.test_context, self.num_consumers, self.kafka,
self.topic, new_consumer=new_consumer, consumer_timeout_ms=30000,
Expand Down