Skip to content

KAFKA-12365; Disable APIs not supported by KIP-500 broker/controller #10194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hachikuji merged 5 commits into from
Feb 26, 2021
Merged

KAFKA-12365; Disable APIs not supported by KIP-500 broker/controller #10194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4ef3db7
KAFKA-12365; Disable transactional APIs on KIP-500 broker
hachikuji Feb 23, 2021
77f86c6
Disable all APIs not supported by kip-500 servers
hachikuji Feb 25, 2021
1650394
Disable transaction system tests with raft quorum
hachikuji Feb 25, 2021
8e48ea5
Reenable `DeleteTopics` which will be fixed soon
hachikuji Feb 26, 2021
254e33c
Also disable raft quorum in `group_mode_transactions_test.py`
hachikuji Feb 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clients/src/main/resources/common/message/AddOffsetsToTxnRequest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
{
"apiKey": 25,
"type": "request",
"listeners": ["zkBroker", "broker"],
"listeners": ["zkBroker"],
"name": "AddOffsetsToTxnRequest",
// Version 1 is the same as version 0.
//
Expand Down
2 changes: 1 addition & 1 deletion clients/src/main/resources/common/message/AddPartitionsToTxnRequest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
{
"apiKey": 24,
"type": "request",
"listeners": ["zkBroker", "broker"],
"listeners": ["zkBroker"],
"name": "AddPartitionsToTxnRequest",
// Version 1 is the same as version 0.
//
Expand Down
2 changes: 1 addition & 1 deletion clients/src/main/resources/common/message/AlterConfigsRequest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
{
"apiKey": 33,
"type": "request",
"listeners": ["zkBroker", "broker", "controller"],
"listeners": ["zkBroker"],
"name": "AlterConfigsRequest",
// Version 1 is the same as version 0.
// Version 2 enables flexible versions.
Expand Down
2 changes: 1 addition & 1 deletion clients/src/main/resources/common/message/AlterPartitionReassignmentsRequest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
{
"apiKey": 45,
"type": "request",
"listeners": ["zkBroker", "broker"],
"listeners": ["zkBroker"],
"name": "AlterPartitionReassignmentsRequest",
"validVersions": "0",
"flexibleVersions": "0+",
Expand Down
2 changes: 1 addition & 1 deletion clients/src/main/resources/common/message/AlterUserScramCredentialsRequest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
{
"apiKey": 51,
"type": "request",
"listeners": ["zkBroker", "broker", "controller"],
"listeners": ["zkBroker"],
"name": "AlterUserScramCredentialsRequest",
"validVersions": "0",
"flexibleVersions": "0+",
Expand Down
2 changes: 1 addition & 1 deletion clients/src/main/resources/common/message/CreateAclsRequest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
{
"apiKey": 30,
"type": "request",
"listeners": ["zkBroker", "broker", "controller"],
"listeners": ["zkBroker"],
"name": "CreateAclsRequest",
// Version 1 adds resource pattern type.
// Version 2 enables flexible versions.
Expand Down
2 changes: 1 addition & 1 deletion clients/src/main/resources/common/message/CreateDelegationTokenRequest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
{
"apiKey": 38,
"type": "request",
"listeners": ["zkBroker", "broker", "controller"],
"listeners": ["zkBroker"],
"name": "CreateDelegationTokenRequest",
// Version 1 is the same as version 0.
//
Expand Down
2 changes: 1 addition & 1 deletion clients/src/main/resources/common/message/CreatePartitionsRequest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
{
"apiKey": 37,
"type": "request",
"listeners": ["zkBroker", "broker", "controller"],
"listeners": ["zkBroker"],
"name": "CreatePartitionsRequest",
// Version 1 is the same as version 0.
//
Expand Down
2 changes: 1 addition & 1 deletion clients/src/main/resources/common/message/DeleteAclsRequest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
{
"apiKey": 31,
"type": "request",
"listeners": ["zkBroker", "broker", "controller"],
"listeners": ["zkBroker"],
"name": "DeleteAclsRequest",
// Version 1 adds the pattern type.
// Version 2 enables flexible versions.
Expand Down
2 changes: 1 addition & 1 deletion clients/src/main/resources/common/message/DescribeAclsRequest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
{
"apiKey": 29,
"type": "request",
"listeners": ["zkBroker", "broker", "controller"],
"listeners": ["zkBroker"],
"name": "DescribeAclsRequest",
// Version 1 adds resource pattern type.
// Version 2 enables flexible versions.
Expand Down
2 changes: 1 addition & 1 deletion clients/src/main/resources/common/message/DescribeClientQuotasRequest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
{
"apiKey": 48,
"type": "request",
"listeners": ["zkBroker", "broker"],
"listeners": ["zkBroker"],

@cmccabe cmccabe Feb 25, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

describeClientQuotas is implemented for kip-500 already (on the broker)

@hachikuji hachikuji Feb 26, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going by this: https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/KafkaApis.scala#L3026.

@cmccabe cmccabe Feb 26, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... looking at trunk, it looks like there are some changes from the KIP-500 branch that didn't make it over. handleDescribeClientQuotasRequest did work in the kip-500 branch. Anyway, at this point, I think we should just disable it and put client quotas support on the TODO list for the next release (sigh)

"name": "DescribeClientQuotasRequest",
// Version 1 enables flexible versions.
"validVersions": "0-1",
Expand Down
2 changes: 1 addition & 1 deletion clients/src/main/resources/common/message/DescribeConfigsRequest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
{
"apiKey": 32,
"type": "request",
"listeners": ["zkBroker", "broker", "controller"],
"listeners": ["zkBroker", "broker"],
"name": "DescribeConfigsRequest",
// Version 1 adds IncludeSynonyms.
// Version 2 is the same as version 1.
Expand Down
2 changes: 1 addition & 1 deletion clients/src/main/resources/common/message/DescribeDelegationTokenRequest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
{
"apiKey": 41,
"type": "request",
"listeners": ["zkBroker", "broker", "controller"],
"listeners": ["zkBroker"],
"name": "DescribeDelegationTokenRequest",
// Version 1 is the same as version 0.
// Version 2 adds flexible version support
Expand Down
2 changes: 1 addition & 1 deletion clients/src/main/resources/common/message/DescribeUserScramCredentialsRequest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
{
"apiKey": 50,
"type": "request",
"listeners": ["zkBroker", "broker", "controller"],
"listeners": ["zkBroker"],
"name": "DescribeUserScramCredentialsRequest",
"validVersions": "0",
"flexibleVersions": "0+",
Expand Down
2 changes: 1 addition & 1 deletion clients/src/main/resources/common/message/ElectLeadersRequest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
{
"apiKey": 43,
"type": "request",
"listeners": ["zkBroker", "broker", "controller"],
"listeners": ["zkBroker"],
"name": "ElectLeadersRequest",
// Version 1 implements multiple leader election types, as described by KIP-460.
//
Expand Down
2 changes: 1 addition & 1 deletion clients/src/main/resources/common/message/EndTxnRequest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
{
"apiKey": 26,
"type": "request",
"listeners": ["zkBroker", "broker"],
"listeners": ["zkBroker"],
"name": "EndTxnRequest",
// Version 1 is the same as version 0.
//
Expand Down
2 changes: 1 addition & 1 deletion clients/src/main/resources/common/message/ExpireDelegationTokenRequest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
{
"apiKey": 40,
"type": "request",
"listeners": ["zkBroker", "broker", "controller"],
"listeners": ["zkBroker"],
"name": "ExpireDelegationTokenRequest",
// Version 1 is the same as version 0.
// Version 2 adds flexible version support
Expand Down
2 changes: 1 addition & 1 deletion clients/src/main/resources/common/message/InitProducerIdRequest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
{
"apiKey": 22,
"type": "request",
"listeners": ["zkBroker", "broker"],
"listeners": ["zkBroker"],
"name": "InitProducerIdRequest",
// Version 1 is the same as version 0.
//
Expand Down
2 changes: 1 addition & 1 deletion clients/src/main/resources/common/message/ListPartitionReassignmentsRequest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
{
"apiKey": 46,
"type": "request",
"listeners": ["zkBroker", "broker"],
"listeners": ["zkBroker"],
"name": "ListPartitionReassignmentsRequest",
"validVersions": "0",
"flexibleVersions": "0+",
Expand Down
2 changes: 1 addition & 1 deletion clients/src/main/resources/common/message/MetadataRequest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
{
"apiKey": 3,
"type": "request",
"listeners": ["zkBroker", "broker"],
"listeners": ["zkBroker", "broker", "controller"],
"name": "MetadataRequest",
"validVersions": "0-11",
"flexibleVersions": "9+",
Expand Down
2 changes: 1 addition & 1 deletion clients/src/main/resources/common/message/RenewDelegationTokenRequest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
{
"apiKey": 39,
"type": "request",
"listeners": ["zkBroker", "broker", "controller"],
"listeners": ["zkBroker"],
"name": "RenewDelegationTokenRequest",
// Version 1 is the same as version 0.
// Version 2 adds flexible version support
Expand Down
2 changes: 1 addition & 1 deletion clients/src/main/resources/common/message/TxnOffsetCommitRequest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
{
"apiKey": 28,
"type": "request",
"listeners": ["zkBroker", "broker"],
"listeners": ["zkBroker"],
"name": "TxnOffsetCommitRequest",
// Version 1 is the same as version 0.
//
Expand Down
2 changes: 1 addition & 1 deletion clients/src/main/resources/common/message/UpdateFeaturesRequest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
{
"apiKey": 57,
"type": "request",
"listeners": ["zkBroker", "broker", "controller"],
"listeners": ["zkBroker"],
"name": "UpdateFeaturesRequest",
"validVersions": "0",
"flexibleVersions": "0+",
Expand Down
Loading