Skip to content

KAFKA-12284: wait for mm2 auto-created the topic #10185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mimaison merged 2 commits into from
Mar 3, 2021
Merged

KAFKA-12284: wait for mm2 auto-created the topic #10185

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0954473
KAFKA-12284: wait for mm2 auto-created the topic
showuon Feb 23, 2021
de95286
KAFKA-12284: don't catch exception in deleteTopics
showuon Feb 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
105 changes: 68 additions & 37 deletions ...java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
import java.util.HashMap;
import java.util.Map;
import java.util.Properties;
import java.util.Set;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicInteger;

Expand Down Expand Up @@ -82,6 +83,7 @@ public abstract class MirrorConnectorsIntegrationBaseTest {
private static final int CHECKPOINT_DURATION_MS = 20_000;
private static final int RECORD_CONSUME_DURATION_MS = 20_000;
private static final int OFFSET_SYNC_DURATION_MS = 30_000;
private static final int TOPIC_SYNC_DURATION_MS = 30_000;
private static final int NUM_WORKERS = 3;
private static final Duration CONSUMER_POLL_TIMEOUT_MS = Duration.ofMillis(500);
protected static final String PRIMARY_CLUSTER_ALIAS = "primary";
Expand Down Expand Up @@ -227,7 +229,10 @@ public void testReplication() throws Exception {

MirrorClient primaryClient = new MirrorClient(mm2Config.clientConfig(PRIMARY_CLUSTER_ALIAS));
MirrorClient backupClient = new MirrorClient(mm2Config.clientConfig(BACKUP_CLUSTER_ALIAS));


// make sure the topic is auto-created in the other cluster
waitForTopicCreated(primary.kafka(), "backup.test-topic-1");
waitForTopicCreated(backup.kafka(), "primary.test-topic-1");
assertEquals(TopicConfig.CLEANUP_POLICY_COMPACT, getTopicConfig(backup.kafka(), "primary.test-topic-1", TopicConfig.CLEANUP_POLICY_CONFIG),
"topic config was not synced");

Expand Down Expand Up @@ -312,6 +317,10 @@ public void testReplication() throws Exception {
primary.kafka().createTopic("test-topic-2", NUM_PARTITIONS);
backup.kafka().createTopic("test-topic-3", NUM_PARTITIONS);

// make sure the topic is auto-created in the other cluster
waitForTopicCreated(backup.kafka(), "primary.test-topic-2");
waitForTopicCreated(primary.kafka(), "backup.test-topic-3");

// only produce messages to the first partition
produceMessages(primary, "test-topic-2", 1);
produceMessages(backup, "test-topic-3", 1);
Expand Down Expand Up @@ -360,15 +369,17 @@ public void testReplicationWithEmptyPartition() throws Exception {
waitForConsumingAllRecords(backupConsumer, expectedRecords);
}

Admin backupClient = backup.kafka().createAdminClient();
// retrieve the consumer group offset from backup cluster
Map<TopicPartition, OffsetAndMetadata> remoteOffsets =
try (Admin backupClient = backup.kafka().createAdminClient()) {
// retrieve the consumer group offset from backup cluster
Map<TopicPartition, OffsetAndMetadata> remoteOffsets =
backupClient.listConsumerGroupOffsets(consumerGroupName).partitionsToOffsetAndMetadata().get();
// pinpoint the offset of the last partition which does not receive records
OffsetAndMetadata offset = remoteOffsets.get(new TopicPartition(PRIMARY_CLUSTER_ALIAS + "." + topic, NUM_PARTITIONS - 1));
// offset of the last partition should exist, but its value should be 0
assertNotNull(offset, "Offset of last partition was not replicated");
assertEquals(0, offset.offset(), "Offset of last partition is not zero");

// pinpoint the offset of the last partition which does not receive records
OffsetAndMetadata offset = remoteOffsets.get(new TopicPartition(PRIMARY_CLUSTER_ALIAS + "." + topic, NUM_PARTITIONS - 1));
// offset of the last partition should exist, but its value should be 0
assertNotNull(offset, "Offset of last partition was not replicated");
assertEquals(0, offset.offset(), "Offset of last partition is not zero");
}
}

@Test
Expand Down Expand Up @@ -396,6 +407,9 @@ public void testOneWayReplicationWithAutoOffsetSync() throws InterruptedExceptio

waitUntilMirrorMakerIsRunning(backup, CONNECTOR_LIST, mm2Config, PRIMARY_CLUSTER_ALIAS, BACKUP_CLUSTER_ALIAS);

// make sure the topic is created in the other cluster
waitForTopicCreated(primary.kafka(), "backup.test-topic-1");
waitForTopicCreated(backup.kafka(), "primary.test-topic-1");
// create a consumer at backup cluster with same consumer group Id to consume 1 topic
Consumer<byte[], byte[]> backupConsumer = backup.kafka().createConsumerAndSubscribeTo(
consumerProps, "primary.test-topic-1");
Expand All @@ -412,7 +426,9 @@ public void testOneWayReplicationWithAutoOffsetSync() throws InterruptedExceptio

// now create a new topic in primary cluster
primary.kafka().createTopic("test-topic-2", NUM_PARTITIONS);
backup.kafka().createTopic("primary.test-topic-2", 1);
// make sure the topic is created in backup cluster
waitForTopicCreated(backup.kafka(), "primary.test-topic-2");

// produce some records to the new topic in primary cluster
produceMessages(primary, "test-topic-2");

Expand Down Expand Up @@ -455,27 +471,41 @@ private static void waitUntilMirrorMakerIsRunning(EmbeddedConnectCluster connect
"Connector " + connector.getSimpleName() + " tasks did not start in time on cluster: " + connectCluster);
}
}


/*
* wait for the topic created on the cluster
*/
private static void waitForTopicCreated(EmbeddedKafkaCluster cluster, String topicName) throws InterruptedException {
try (final Admin adminClient = cluster.createAdminClient()) {
waitForCondition(() -> adminClient.listTopics().names().get().contains(topicName), TOPIC_SYNC_DURATION_MS,
"Topic: " + topicName + " didn't get created in the cluster"
);
}
}

/*
* delete all topics of the input kafka cluster
*/
private static void deleteAllTopics(EmbeddedKafkaCluster cluster) throws Exception {
Admin client = cluster.createAdminClient();
client.deleteTopics(client.listTopics().names().get());
try (final Admin adminClient = cluster.createAdminClient()) {
Set<String> topicsToBeDeleted = adminClient.listTopics().names().get();
log.debug("Deleting topics: {} ", topicsToBeDeleted);
adminClient.deleteTopics(topicsToBeDeleted).all().get();
}
}

/*
* retrieve the config value based on the input cluster, topic and config name
*/
private static String getTopicConfig(EmbeddedKafkaCluster cluster, String topic, String configName)
throws Exception {
Admin client = cluster.createAdminClient();
Collection<ConfigResource> cr = Collections.singleton(
new ConfigResource(ConfigResource.Type.TOPIC, topic));

DescribeConfigsResult configsResult = client.describeConfigs(cr);
Config allConfigs = (Config) configsResult.all().get().values().toArray()[0];
return allConfigs.get(configName).value();
private static String getTopicConfig(EmbeddedKafkaCluster cluster, String topic, String configName) throws Exception {
try (Admin client = cluster.createAdminClient()) {
Collection<ConfigResource> cr = Collections.singleton(
new ConfigResource(ConfigResource.Type.TOPIC, topic));

DescribeConfigsResult configsResult = client.describeConfigs(cr);
Config allConfigs = (Config) configsResult.all().get().values().toArray()[0];
return allConfigs.get(configName).value();
}
}

/*
Expand Down Expand Up @@ -505,27 +535,28 @@ protected void produceMessages(EmbeddedConnectCluster cluster, String topicName,
private static <T> void waitForConsumerGroupOffsetSync(EmbeddedConnectCluster connect,
Consumer<T, T> consumer, List<String> topics, String consumerGroupId, int numRecords)
throws InterruptedException {
Admin adminClient = connect.kafka().createAdminClient();
List<TopicPartition> tps = new ArrayList<>(NUM_PARTITIONS * topics.size());
for (int partitionIndex = 0; partitionIndex < NUM_PARTITIONS; partitionIndex++) {
for (String topic : topics) {
tps.add(new TopicPartition(topic, partitionIndex));
try (Admin adminClient = connect.kafka().createAdminClient()) {
List<TopicPartition> tps = new ArrayList<>(NUM_PARTITIONS * topics.size());
for (int partitionIndex = 0; partitionIndex < NUM_PARTITIONS; partitionIndex++) {
for (String topic : topics) {
tps.add(new TopicPartition(topic, partitionIndex));
}
}
}
long expectedTotalOffsets = numRecords * topics.size();
long expectedTotalOffsets = numRecords * topics.size();

waitForCondition(() -> {
Map<TopicPartition, OffsetAndMetadata> consumerGroupOffsets =
waitForCondition(() -> {
Map<TopicPartition, OffsetAndMetadata> consumerGroupOffsets =
adminClient.listConsumerGroupOffsets(consumerGroupId).partitionsToOffsetAndMetadata().get();
long consumerGroupOffsetTotal = consumerGroupOffsets.values().stream()
long consumerGroupOffsetTotal = consumerGroupOffsets.values().stream()
.mapToLong(OffsetAndMetadata::offset).sum();

Map<TopicPartition, Long> offsets = consumer.endOffsets(tps, CONSUMER_POLL_TIMEOUT_MS);
long totalOffsets = offsets.values().stream().mapToLong(l -> l).sum();
Map<TopicPartition, Long> offsets = consumer.endOffsets(tps, CONSUMER_POLL_TIMEOUT_MS);
long totalOffsets = offsets.values().stream().mapToLong(l -> l).sum();

// make sure the consumer group offsets are synced to expected number
return totalOffsets == expectedTotalOffsets && consumerGroupOffsetTotal > 0;
}, OFFSET_SYNC_DURATION_MS, "Consumer group offset sync is not complete in time");
// make sure the consumer group offsets are synced to expected number
return totalOffsets == expectedTotalOffsets && consumerGroupOffsetTotal > 0;
}, OFFSET_SYNC_DURATION_MS, "Consumer group offset sync is not complete in time");
}
}

/*
Expand Down