KAFKA-12258: Add support for splitting appending records#10063
Merged
Conversation
mumrah
reviewed
Feb 9, 2021
Member
Author
|
@mumrah I found a few more issues on how we compute the needed sizes. I need to fix one of the remaining issues and write tests for them. Let's assume that this PR is still a WIP. |
Member
Author
|
@mumrah Ready for review. Fixed the size calculation issues that I discovered when implementing this PR. |
hachikuji
reviewed
Feb 16, 2021
Contributor
There was a problem hiding this comment.
Thanks for the patch. I think we might need changes in RaftManager as well to ensure that max.message.bytes gets set correctly for the @metadata log. I think currently we take the configuration from the general kafka configuration, which is probably not what we want. I wonder if there are any other overridable configurations that could cause us trouble.
hachikuji
reviewed
Feb 17, 2021
hachikuji
reviewed
Feb 18, 2021
hachikuji
reviewed
Feb 19, 2021
Member
Author
|
Running the following commands |
Member
Author
|
The following tests failed: |
hachikuji
pushed a commit
that referenced
this pull request
Feb 19, 2021
1. Type `BatchAccumulator`. Add support for appending records into one or more batches. 2. Type `RaftClient`. Rename `scheduleAppend` to `scheduleAtomicAppend`. 3. Type `RaftClient`. Add a new method `scheduleAppend` which appends records to the log using as many batches as necessary. 4. Increase the batch size from 1MB to 8MB. Reviewers: David Arthur <mumrah@gmail.com>, Jason Gustafson <jason@confluent.io>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BatchAccumulator. Add support for appending records into one or more batches.RaftClient. RenamescheduleAppendtoscheduleAtomicAppend.RaftClient. Add a new methodscheduleAppendwhich appends records to the log using as many batches as necessary.More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)