Skip to content

Update docs for 1.0.2 release#149

Merged
mjsax merged 1 commit into
apache:asf-sitefrom
mjsax:docs-102
Jul 16, 2018
Merged

Update docs for 1.0.2 release#149
mjsax merged 1 commit into
apache:asf-sitefrom
mjsax:docs-102

Conversation

@mjsax

@mjsax mjsax commented Jul 8, 2018

Copy link
Copy Markdown
Member

No description provided.

@mjsax
mjsax requested review from guozhangwang and ijuma July 8, 2018 21:56

@guozhangwang guozhangwang left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, otherwise lgtm.

Please feel free to merge afterwards.

Comment thread 10/upgrade.html
<h5><a id="upgrade_100_streams" href="#upgrade_100_streams">Upgrading a 1.0.0 Kafka Streams Application</a></h5>
<h5><a id="upgrade_100_streams_from_0110" href="#upgrade_100_streams_from_0110">Upgrading a 0.11.0 Kafka Streams Application</a></h5>
<ul>
<li> Upgrading your Streams application from 0.11.0 to 1.0.0 does not require a broker upgrade.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 134 above: to 1.0.2 or 1.0.x or 1.0 ?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole section is about upgrading to 1.0. I just fixed the headline, because is says 1.0.0 what is incorrect (upgrading from 1.0.0 to 1.0 does not make sense)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guozhangwang Merging this as-is. If you have further comments, we can do a follow up PR.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concern was that, after 1.0.2 is released, the docs under 10 would actually for 1.0.2, so the content mentioning upgrading to 1.0.0 may be a bit confusing.

Maybe we can just rename all the versions in content to only include up to minor digits, like 1.0, or say 1.0.x so that when we release new bug-fix versions we do not need to change the versions any more.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjsax
mjsax merged commit bc87993 into apache:asf-site Jul 16, 2018
@mjsax
mjsax deleted the docs-102 branch July 16, 2018 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants