Skip to content

[IOTDB-753] Add a judgement before removing entry from tag inverted index #1328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qiaojialin merged 2 commits into from
Jun 9, 2020
Merged

[IOTDB-753] Add a judgement before removing entry from tag inverted index #1328

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9220fe7
add a judgement before remove entry from tag inverted index
JackieTien97 Jun 8, 2020
205d6a7
add isWarnEnabled
qiaojialin Jun 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 19 additions & 8 deletions server/src/main/java/org/apache/iotdb/db/metadata/MManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,11 +453,21 @@ private void removeFromTagInvertedIndex(LeafMNode node) throws IOException {
tagLogFile.readTag(config.getTagAttributeTotalSize(), node.getOffset());
if (tagMap != null) {
for (Entry<String, String> entry : tagMap.entrySet()) {
tagIndex.get(entry.getKey()).get(entry.getValue()).remove(node);
if (tagIndex.get(entry.getKey()).get(entry.getValue()).isEmpty()) {
tagIndex.get(entry.getKey()).remove(entry.getValue());
if (tagIndex.get(entry.getKey()).isEmpty()) {
tagIndex.remove(entry.getKey());
if (tagIndex.containsKey(entry.getKey()) && tagIndex.get(entry.getKey())
.containsKey(entry.getValue())) {
tagIndex.get(entry.getKey()).get(entry.getValue()).remove(node);
if (tagIndex.get(entry.getKey()).get(entry.getValue()).isEmpty()) {
tagIndex.get(entry.getKey()).remove(entry.getValue());
if (tagIndex.get(entry.getKey()).isEmpty()) {
tagIndex.remove(entry.getKey());
}
}
} else {
if (logger.isWarnEnabled()) {
logger.warn(String.format(
"TimeSeries %s's tag info has been removed from tag inverted index before "
+ "deleting it, tag key is %s, tag value is %s",
node.getFullPath(), entry.getKey(), entry.getValue()));
}
}
}
Expand Down Expand Up @@ -972,7 +982,7 @@ public StorageGroupMNode getStorageGroupNode(String path) throws MetadataExcepti

/**
* get device node, if the storage group is not set, create it when autoCreateSchema is true
*
* <p>
* (we develop this method as we need to get the node's lock after we get the lock.writeLock())
*
* <p>!!!!!!Attention!!!!! must call the return node's readUnlock() if you call this method.
Expand Down Expand Up @@ -1573,8 +1583,9 @@ public Map<String, String> determineStorageGroup(String path) throws IllegalPath
}

/**
* if the path is in local mtree, nothing needed to do (because mtree is in the memory);
* Otherwise cache the path to mRemoteSchemaCache
* if the path is in local mtree, nothing needed to do (because mtree is in the memory); Otherwise
* cache the path to mRemoteSchemaCache
*
* @param path
* @param schema
*/
Expand Down