-
Notifications
You must be signed in to change notification settings - Fork 566
[INLONG-1720] Introduce the basic framework for a workflow based on flinksql #1721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1721 +/- ##
============================================
- Coverage 12.21% 12.19% -0.03%
- Complexity 1048 1049 +1
============================================
Files 392 392
Lines 32755 32755
Branches 5159 5159
============================================
- Hits 4001 3993 -8
- Misses 27989 27997 +8
Partials 765 765
Continue to review full report at Codecov.
|
|
This PR can make Sort's flow information more obvious, but I personally think it might be better to put it under the sort module as a sub-module of Sort. How about this PR? @ifndef-SleePy |
|
hi @gosonzhang @dockerzhang, thanks for review The key point is we need use high flink version(e.g flink-1.13.x)
In general, if we use old flink version, we will spend most time on flink framework instead of flinksql workflow job, on the other hand, we will not expose flink to end users. And, I had tried put the basic framework to the sort module and upgrade the flink version in sort module, but met many errors. |
|
@leo65535 Flink will not be updated (from 1.9.x->1.13.x) recently, but we have noted this potential problem. I think you could continue to complete your task about this issue at your branch, we could move forward to merge after flink be updated in the future. |
|
@leo65535 how about using |
Make sense.
If not update the flink version, we can not go on, because flink1.9.x has many limits, like
We can refer to other projects, already upgraded the flink version. apache/hudi#3291 Can we use a new module first with new flink version, and keep working on it, so we can support flinksql workflow quickly. |
ok, close first. |
Fixes #1720
Motivation
Introduce the basic framework for a workflow based on flinksql.
Modifications
Add basic flinksql executor.
Verifying this change
Demo
Try a demo, please run
org.apache.inlog.sort.examples.BasicDemoExample.One source, insert into two sink.
Documentation