Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

[iOS] fix bundleType #2606

Merged
merged 3 commits into from
Jun 28, 2019
Merged

[iOS] fix bundleType #2606

merged 3 commits into from
Jun 28, 2019

Conversation

mario-huang
Copy link
Contributor

bundleType can be Vue, Rax
when the bundleType is "vue", the program goes bundleType = "other"

bundleType can be Vue, Rax
when the bundleType is "vue", the program goes bundleType = "other"
@mario-huang mario-huang requested a review from wqyfavor as a code owner June 24, 2019 09:27
@weex-bot
Copy link

weex-bot commented Jun 24, 2019

Messages
📖 No android file has been changed.
📖 android build verification finished.

Generated by 🚫 dangerJS

@mario-huang
Copy link
Contributor Author

@wqyfavor Please review, the fix is very important to our product!

@YorkShen
Copy link
Contributor

YorkShen commented Jun 26, 2019

I am not an iOS developer, but at least you should support Vue/vue and Rax/rax together.

[iOS] fix bundleType
@mario-huang
Copy link
Contributor Author

As you wish, I support Vue/vue and Rax/rax together.

Copy link
Contributor

@jianhan-he jianhan-he left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jianhan-he jianhan-he merged commit 7a8201c into apache:master Jun 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants