Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

[Android] add new white screen check logic #2582

Merged
merged 1 commit into from
Jun 19, 2019

Conversation

lucky-chen
Copy link
Contributor

@lucky-chen lucky-chen commented Jun 19, 2019

white screen check (if didn't render LeafView )

  • report view/component tree
  • report run state (task、jsc crash、reload)

@lucky-chen lucky-chen force-pushed the feature/ws_checknew branch 4 times, most recently from 6406b66 to f2b7cca Compare June 19, 2019 11:26
Darin726
Darin726 previously approved these changes Jun 19, 2019
Copy link
Contributor

@Darin726 Darin726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -236,6 +236,10 @@ public void postOnUiThread(Runnable runnable, long delayMillis) {
mWXRenderManager.postOnUiThread(WXThread.secure(runnable), delayMillis);
}

public void removeUITask(Runnable runnable){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个代码也可以删掉了

Copy link
Contributor

@YorkShen YorkShen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing Apache License Header

@@ -0,0 +1,128 @@
package com.taobao.weex.performance;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APL License Header

Copy link
Contributor

@YorkShen YorkShen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YorkShen YorkShen merged commit ec44cd4 into apache:master Jun 19, 2019
katherine95s pushed a commit to katherine95s/incubator-weex that referenced this pull request Jul 4, 2019
katherine95s pushed a commit to katherine95s/incubator-weex that referenced this pull request Jul 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants