Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

[Android] Disable all log level in release app and enable log level above debug app. #2581

Merged
merged 2 commits into from
Jun 19, 2019

Conversation

YorkShen
Copy link
Contributor

  1. Add a variable (DebugMode) in namespace of WeexCore. Sub-process and main-process would WeexCore::DebugMode separately.
  2. The default log out is enable only if WeexCore::DebugMode is true.
  3. As for LOGD printed before sub-process setting WeexCore::DebugMode, just delete -DDEBUG=1 in CMAKE

This is not a final fix, just a temporary one.

1. Add a variable (DebugMode) in namespace of WeexCore. Sub-process and main-process would WeexCore::DebugMode separately.
2. The default log out is enable only if WeexCore::DebugMode is true.
3. As for LOGD printed before sub-process setting WeexCore::DebugMode, just delete -DDEBUG=1 in CMAKE
@YorkShen YorkShen requested a review from Darin726 as a code owner June 19, 2019 08:47
Copy link
Contributor

@Darin726 Darin726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Darin726 Darin726 merged commit 2a7f46f into apache:master Jun 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants