This repository has been archived by the owner on Jun 3, 2021. It is now read-only.
[Android] Check weexVersion #2451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. The version must have 4 sections. 2. The leading three section must be number, and the last section is odd number with or without suffix string.
Generated by 🚫 dangerJS |
lucky-chen
reviewed
May 16, 2019
| version = project.hasProperty('weexVersion') ? project.getProperty('weexVersion') : "0.20.0.1" | ||
|
|
||
| //Check version, the version must have 4 sections. The leading three section must be number, and the last section is odd number with or without suffix string. | ||
| if (!project.hasProperty('ignoreVersionCheck') || !project.getProperty('ignoreVersionCheck').equals("true")) { |
There was a problem hiding this comment.
should be project.getProperty('ignoreVersionCheck').equals("true")?
There was a problem hiding this comment.
Nope
It is another form of ! (project.hasProperty('ignoreVersionCheck') && project.getProperty('ignoreVersionCheck).equals("true"))
YorkShen
added a commit
that referenced
this pull request
May 24, 2019
* [Android] Check weexVersion 1. The version must have 4 sections. 2. The leading three section must be number, and the last section is odd number with or without suffix string. * [Android] Add ignoreVersionCheck (cherry picked from commit 151c469)
lucky-chen
pushed a commit
that referenced
this pull request
May 24, 2019
* [jsfm] Fix the lint error in Document (#2368) Remove the useless temporary variable `result` in the `fireEvent` method. * [iOS] Fix mtl target build script. (#2369) * Update version for 0.24 release * Update release script * Add release_candiate.sh * Chmod publish_release_candiate.sh to 755 * Update publish.sh * Update push tag * Update publish srcript * Update license header and build script for apache release. * Update file header for source file from Webkit and chromium * Update webkit version. * update publish script. * Update push tag * update publish script * Update rule for release_files. * Add Ninja build dep (#2459) * Update publish_release_official script. * Update license * Update release script * Update comment doc release script. * Update readme * Update Readme.md * [Android] Check weexVersion (#2451) * [Android] Check weexVersion 1. The version must have 4 sections. 2. The leading three section must be number, and the last section is odd number with or without suffix string. * [Android] Add ignoreVersionCheck (cherry picked from commit 151c469) * [Android] Copy so. (#2454) Use a dedicated way to copy unstripped .so file without the importable file path. (cherry picked from commit 4da0cea) * Remove ios/sdk/WeexTests/dependency from Apache release. * Update build.gradle
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.20.0.1-PignoreVersionCheck=true