Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

[Android] feature : check bundle_type and report error #2424

Merged
merged 1 commit into from
May 9, 2019

Conversation

lucky-chen
Copy link
Contributor

@weex-bot
Copy link

weex-bot commented May 9, 2019

Fails
🚫 Failed to run assembleDebug task for android.
Messages
📖 android build verification finished.

Generated by 🚫 dangerJS

Copy link
Contributor

@YorkShen YorkShen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also consider invoking commitCriticalExceptionRT when eagle js downloading succeses.

Ref

String bundleTypeStr = bundleType == null ? "Others" : bundleType.toString();

@lucky-chen lucky-chen force-pushed the feature_check_bundle_type branch from 8a2bd66 to a90f72d Compare May 9, 2019 08:53
[Android] add eagle bundle type check
@lucky-chen lucky-chen force-pushed the feature_check_bundle_type branch from a90f72d to dbc6498 Compare May 9, 2019 09:00
Copy link
Contributor

@YorkShen YorkShen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YorkShen YorkShen merged commit b5dd77c into apache:master May 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants