Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

[iOS] Don't rescale corner-radius because some animation may animate … #2112

Merged
merged 1 commit into from
Feb 12, 2019

Conversation

wqyfavor
Copy link
Member

…width/height from zero to some value, but scaling generates zero factor if width/height is zero.

First of all, thank you for your contribution!

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

CheckList:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update test scripts for the feature.
  • Add unit tests for the feature.

…width/height from zero to some value, but scaling generates zero factor if width/height is zero.
@weex-bot
Copy link

weex-bot commented Feb 11, 2019

Messages
📖 No android file has been changed.
📖 android build verification finished.

Generated by 🚫 dangerJS

Copy link
Contributor

@jianhan-he jianhan-he left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@doumafang doumafang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@doumafang doumafang merged commit c30032d into apache:master Feb 12, 2019
wqyfavor pushed a commit to wqyfavor/incubator-weex that referenced this pull request Feb 12, 2019
…animate width/height from zero to some value, but scaling generates zero factor if width/height is zero. (apache#2112)"

This reverts commit c30032d.
doumafang pushed a commit that referenced this pull request Feb 12, 2019
…animate width/height from zero to some value, but scaling generates zero factor if width/height is zero. (#2112)" (#2117)

This reverts commit c30032d.
@wqyfavor wqyfavor deleted the fix-border-ani branch February 12, 2019 08:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants