This repository has been archived by the owner on Jun 3, 2021. It is now read-only.
[WEEX-653][android][iOS][core] Total platform support rtl direction by CSS "direction:rtl" #1664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
August 31, 2018 14:18
Generated by 🚫 dangerJS |
# Conflicts: # ios/sdk/WeexSDK/Sources/Model/WXSDKInstance.m
YorkShen
reviewed
Nov 14, 2018
android/sdk/src/main/java/com/taobao/weex/layout/measurefunc/TextContentBoxMeasurement.java
Outdated
Show resolved
Hide resolved
YorkShen
reviewed
Nov 14, 2018
added 7 commits
November 14, 2018 21:00
katherine95s
pushed a commit
to katherine95s/incubator-weex
that referenced
this pull request
Jul 4, 2019
katherine95s
pushed a commit
to katherine95s/incubator-weex
that referenced
this pull request
Jul 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[android][ios][core] Total platform support rtl direction by CSS "direction:rtl"
[core] Update the new layout engine to support inheritable CSS "direction:rtl".
[ios][android] Update component layer, to support list, slide, scroller RTL direction. Update WXEnvironment, now we can get system layout direction by WXEnvironment.layoutDirection. Update WXDomModule, now we can get element layout direction by getLayoutDirection(ref,callback)
Few languages such as Arabic, Hebrew, or Persian are written from Right to Left, but weex not support RTL layouts. To handle them. Since this PR merged, we can use weex for RTL languages in both android and ios. And Scroller performance like native, layout and scroll direction will be reverse.
There are some test Demos:
Div+Scroller http://dotwe.org/vue/9c3ee9824dd49111a87a93ea6513039a
Horizontal Scroller http://dotwe.org/vue/0dd282e3183c2384ec38a465c915ce41
Scroller (ScrollToElement) http://dotwe.org/vue/a24001978199df6e981673e9460598c8
Slider http://dotwe.org/vue/7e45bcf71ad396032944bc51541d6350
Animation http://dotwe.org/vue/b578facdbb623f6922f0905ae09b7e49
envDirection + getLayoutDirection http://dotwe.org/vue/d6c5cf7a2a907c33cf4ba25fea6e6ef4