-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[WEEX-241][iOS] add WXVideoComponent "poster" attribute #1051
Conversation
Generated by 🚫 dangerJS |
hi, @xuyouyang what's the "poster" feature, is it the paused picture about player display? |
NO. |
@xuyouyang I got it and find the w3c rules about it : https://developer.mozilla.org/en-US/docs/Web/HTML/Element/video thanks, we can make it more standard by add more attributes and styles, what about Android? |
@@ -85,6 +89,13 @@ - (id)init | |||
} | |||
|
|||
[self addSubview:_playerViewController.view]; | |||
|
|||
_posterImageView = [[UIImageView alloc] init]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about lazy load when front-end developer specify the poster attributes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good ideal! I will modify this later.
@xuyouyang as the development process shows, we need create a jira issue in apache, and format your pull request title and commit log. I have created a jira issue for this feature, and the issue id is WEEX-241, the issue address is https://issues.apache.org/jira/browse/WEEX-241 what you need to do next is to update the title as the following format thanks |
OK. Thank you very much! @acton393 |
Lazy load UIImageView property.
@xuyouyang It look good to me and it will be accepted, thank you. |
@acton393 Ha, it's sorry that I am not familiar with Android develop very much.😂 |
feature:241