[Fix] First remove invalid timers and the report. (#2549)

apache · Jun 14, 2019 · 1201d50 · 1201d50
1 parent 6a16112
commit 1201d50
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/ios/sdk/WeexSDK/Sources/Module/WXTimerModule.m b/ios/sdk/WeexSDK/Sources/Module/WXTimerModule.m
@@ -169,11 +169,6 @@ - (void)createTimerWithCallback:(NSString *)callbackID time:(NSTimeInterval)mill
         _timers[callbackID] = timer;
 
         if ([_timers count] > 30) {
-            if (!_tooManyTimersReported) {
-                [WXExceptionUtils commitCriticalExceptionRT:self.weexInstance.instanceId errCode:[NSString stringWithFormat:@"%d", WX_KEY_EXCEPTION_TOO_MANY_TIMERS] function:@"" exception:@"Too many timers." extParams:nil];
-                _tooManyTimersReported = YES;
-            }
-
             // remove invalid timers
             NSMutableArray* invalidTimerIds = [[NSMutableArray alloc] init];
             for (NSString *cbId in _timers) {
@@ -183,6 +178,14 @@ - (void)createTimerWithCallback:(NSString *)callbackID time:(NSTimeInterval)mill
                 }
             }
             [_timers removeObjectsForKeys:invalidTimerIds];
+
+            // If alive timer count still exceeds 30, we report once for this page.
+            if ([_timers count] > 30) {
+                if (!_tooManyTimersReported) {
+                    [WXExceptionUtils commitCriticalExceptionRT:self.weexInstance.instanceId errCode:[NSString stringWithFormat:@"%d", WX_KEY_EXCEPTION_TOO_MANY_TIMERS] function:@"" exception:@"Too many timers." extParams:nil];
+                    _tooManyTimersReported = YES;
+                }
+            }
         }
     }
 }