Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] StreamPark Platform configuration files improvements #3653

Merged
merged 12 commits into from
Apr 2, 2024

Conversation

wolfboys
Copy link
Member

@wolfboys wolfboys commented Apr 2, 2024

Currently, the streampark platform provides multiple configuration files for user configuration, such as: application.yml, application-pgsql.yml, application-mysql.yml, kerberos.yml... , We can improve these configuration files. Many config files are internal system configurations, for example, in application.yml, a large number of configurations are internal platform configurations, such as jackson config for integration Spring Boot, swagger-ui config. the 'allow-circular-references' parameter for Spring... These do not need user configuration and should not be exposed to users.

So, I propose that we improve these configurations by providing users with only one configuration file(only one). The configurations in this file should be completely user-focused, clear, and core configurations.

What changes were proposed in this pull request

Issue Number: close #3641

Brief change log

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

Does this pull request potentially affect one of the following parts

  • Dependencies (does it add or upgrade a dependency): (yes / no)

Copy link
Member

@GOODBOY008 GOODBOY008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GOODBOY008 GOODBOY008 merged commit c83200a into dev-2.1.4 Apr 2, 2024
8 checks passed
@caicancai caicancai deleted the conf branch April 2, 2024 12:21
Mrart pushed a commit to Mrart/incubator-streampark that referenced this pull request May 11, 2024
…e#3653)

* [Improve] streampark console config improvements

* [Improve] minor improvements

* [Improve] config improvements

* [Improve] minor improve

* [Improve] mybatisConfig improvements

* [Improve] logback config improve

* [Improve] spring.datasource.driver-class-name improvements

* [Improve] PropertiesUtils null value improvement

* [Improve] spring conf improve

* [Improve] config improvements

* [Improve] springTest ci failed fixed

* [Improve] testcase bug fixed.

---------

Co-authored-by: benjobs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants