Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] table resize icon #3525

Merged
merged 3 commits into from
Jan 30, 2024
Merged

[Improve] table resize icon #3525

merged 3 commits into from
Jan 30, 2024

Conversation

wangsizhu0504
Copy link
Member

What changes were proposed in this pull request

Issue Number: close #xxx

Brief change log

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

  1. app page form add column drag and drop icon, limit jobName column width to minimum 100px
2024-01-30.21.54.18.mov
image

Does this pull request potentially affect one of the following parts

  • Dependencies (does it add or upgrade a dependency): (yes / no)

@wangsizhu0504
Copy link
Member Author

cc @wolfboys I have added drag and drop icons to the table columns in the app view interface.

Copy link
Member

@wolfboys wolfboys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caicancai caicancai changed the title improve: table resize icon [Improve]: table resize icon Jan 30, 2024
@caicancai caicancai changed the title [Improve]: table resize icon [Improve] table resize icon Jan 30, 2024
@caicancai caicancai merged commit 50d0402 into apache:dev-2.1.3 Jan 30, 2024
3 checks passed
@caicancai
Copy link
Member

@wangsizhu0504 Can you submit another PR to the dev branch, thank you

@wangsizhu0504
Copy link
Member Author

@wangsizhu0504 Can you submit another PR to the dev branch, thank you

ok! I will submit a new PR later

@wangsizhu0504 wangsizhu0504 deleted the improve/resize branch February 17, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants