Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Trigger method add savepoint save #3493

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

gwy1995
Copy link

@gwy1995 gwy1995 commented Jan 17, 2024

Contribution Checklist

  • If this is your first time, please read our contributor guidelines: Submit Code.

  • Make sure that the pull request corresponds to a GITHUB issue.

  • Name the pull request in the form "[Feature] Title of the pull request", where Feature can be replaced by Hotfix, Bug, etc.

  • Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.

  • If the PR is unfinished, add [WIP] in your PR title, e.g., [WIP][Feature] Title of the pull request.

What changes were proposed in this pull request

Brief change log

  • Add savepoint record to t_savepoint when trigger savepoint

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts

  • Dependencies (does it add or upgrade a dependency): no

@caicancai caicancai requested a review from wolfboys January 19, 2024 01:59
Copy link
Member

@wolfboys wolfboys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wolfboys wolfboys merged commit 5964856 into apache:dev-2.1.3 Jan 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants