-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize:optimize time query conditions in the console #6285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some UT failed. |
slievrly
reviewed
Jan 22, 2024
server/src/main/java/io/seata/server/console/impl/db/GlobalLockDBServiceImpl.java
Outdated
Show resolved
Hide resolved
xingfudeshi
changed the title
bugfix:fix time query conditions in the console
(WIP)bugfix:fix time query conditions in the console
Jan 23, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6285 +/- ##
============================================
- Coverage 51.95% 51.93% -0.03%
+ Complexity 5174 5170 -4
============================================
Files 918 918
Lines 32039 32045 +6
Branches 3866 3866
============================================
- Hits 16647 16643 -4
- Misses 13767 13776 +9
- Partials 1625 1626 +1
|
xingfudeshi
changed the title
(WIP)bugfix:fix time query conditions in the console
bugfix:fix time query conditions in the console
Jan 24, 2024
xingfudeshi
changed the title
bugfix:fix time query conditions in the console
optimize:optimize time query conditions in the console
Jan 24, 2024
slievrly
reviewed
Jan 26, 2024
slievrly
reviewed
Jan 26, 2024
…fix-console-time-fitler
…shi/seata into fix-console-time-fitler # Conflicts: # changes/en-us/2.x.md # changes/zh-cn/2.x.md
slievrly
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In terms of function, this actually belongs to bugfix.
ok |
ptyin
pushed a commit
to ptyin/seata
that referenced
this pull request
Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #6272
Ⅲ. Why don't you add test cases (unit test/integration test)?
I've already tested file mode and database mode locally
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews