Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: asf config file format error #6196

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Conversation

AlbumenJ
Copy link
Member

@AlbumenJ AlbumenJ commented Dec 22, 2023

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Update format according to https://cwiki.apache.org/confluence/pages/viewpage.action?spaceKey=INFRA&title=git+-+.asf.yaml+features

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2ed693b) 49.04% compared to head (7798f2f) 48.99%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6196      +/-   ##
============================================
- Coverage     49.04%   48.99%   -0.05%     
+ Complexity     4784     4782       -2     
============================================
  Files           915      915              
  Lines         31892    31892              
  Branches       3853     3853              
============================================
- Hits          15640    15625      -15     
- Misses        14697    14706       +9     
- Partials       1555     1561       +6     

see 6 files with indirect coverage changes

@funky-eyes funky-eyes changed the title Update asf config file bugfix: asf config file format error Dec 22, 2023
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 2.1.0 milestone Dec 22, 2023
@funky-eyes funky-eyes added the type: bug Category issues or prs related to bug. label Dec 22, 2023
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi
Copy link
Member

@AlbumenJ Please register this PR in change log

@slievrly slievrly merged commit 9a58770 into apache:2.x Dec 22, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants