Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: fix asf.yaml parse error #6194

Merged
merged 6 commits into from
Dec 22, 2023
Merged

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Dec 21, 2023

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

fix asf.yaml parse error

Ⅱ. Does this pull request fix one issue?

fix #6193

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (81fc703) 49.00% compared to head (a76b811) 48.96%.
Report is 1 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6194      +/-   ##
============================================
- Coverage     49.00%   48.96%   -0.04%     
+ Complexity     4783     4778       -5     
============================================
  Files           915      915              
  Lines         31890    31892       +2     
  Branches       3853     3853              
============================================
- Hits          15627    15616      -11     
- Misses        14700    14717      +17     
+ Partials       1563     1559       -4     
Files Coverage Δ
...eata/core/rpc/netty/NettyClientChannelManager.java 62.50% <100.00%> (+2.21%) ⬆️
...ain/java/io/seata/core/rpc/netty/NettyPoolKey.java 72.72% <0.00%> (-13.76%) ⬇️

... and 3 files with indirect coverage changes

changes/en-us/2.x.md Outdated Show resolved Hide resolved
changes/zh-cn/2.x.md Outdated Show resolved Hide resolved
changes/en-us/2.x.md Outdated Show resolved Hide resolved
changes/zh-cn/2.x.md Outdated Show resolved Hide resolved
@funky-eyes funky-eyes added this to the 2.1.0 milestone Dec 21, 2023
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi xingfudeshi merged commit 2ed693b into apache:2.x Dec 22, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parse asf.yaml error
5 participants