This repository has been archived by the owner on Feb 8, 2019. It is now read-only.
GEARPUMP-215 Gearpump Redis Integration - RedisSink #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 71.34% (diff: 100%)@@ master #93 diff @@
==========================================
Files 186 186
Lines 5985 5985
Methods 5464 5464
Messages 0 0
Branches 521 521
==========================================
- Hits 4283 4270 -13
- Misses 1702 1715 +13
Partials 0 0
|
manuzhang
reviewed
Oct 10, 2016
| * @param database | ||
| * @param password | ||
| */ | ||
| class RedisStorage( |
There was a problem hiding this comment.
Better name it RedisSink since it extends DataSink interface
manuzhang
reviewed
Oct 10, 2016
| import redis.clients.jedis.Protocol.{DEFAULT_DATABASE, DEFAULT_HOST, DEFAULT_PORT, DEFAULT_TIMEOUT} | ||
|
|
||
| /** | ||
| * Save message in Redis Instance |
There was a problem hiding this comment.
please fix the comment style. If you are using Intellij, please go to Editor => Code Style => Scala, switch to Wrapping and Braces tab, click on Keep when reformatting and check Comment at first column
|
looks good overall despite minor naming and style things |
darionyaphet
force-pushed
the
GEARPUMP-215
branch
from
eee4320 to
1bfab21
Compare
darionyaphet
changed the title
|
@darionyaphet +1, thanks for your contribution. Please keep the good work. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gearpump Redis Integration - RedisStorage