Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Example]fix argument in cpp inception_bn example #13185

Closed
wants to merge 2 commits into from

Conversation

roywei
Copy link
Member

@roywei roywei commented Nov 8, 2018

Description

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Update argument in Pooling

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@roywei roywei requested a review from nswamy as a code owner November 8, 2018 17:28
@anirudhacharya
Copy link
Member

@mxnet-label-bot [pr-awaiting-review, Example]

@marcoabreu marcoabreu added Example pr-awaiting-review PR is waiting for code review labels Nov 8, 2018
@nswamy
Copy link
Member

nswamy commented Nov 8, 2018

@roywei can you please fix lint errors?

@roywei roywei changed the title fix argument in cpp inception_bn example [Example]fix argument in cpp inception_bn example Nov 8, 2018
Copy link
Member

@nswamy nswamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this example, does the example have some testing? if not please add some nightly tests.

@kalyc
Copy link
Contributor

kalyc commented Nov 13, 2018

@mxnet-label-bot update [pr-awaiting-response]

@marcoabreu marcoabreu added pr-awaiting-response PR is reviewed and waiting for contributor to respond and removed Example pr-awaiting-review PR is waiting for code review labels Nov 13, 2018
@roywei
Copy link
Member Author

roywei commented Nov 13, 2018

@nswamy when adding to tests, I found training acc does not increase. It's happening in other models as well. I have created another issue to track and fix.#13243 Most likely root cause will not be relavant to the training scripts here as other models have the same problem.

While this PR can fix the inception-bn example and make it runnable, can we merge it first?

@roywei
Copy link
Member Author

roywei commented Nov 13, 2018

@leleamol Could you take a look? Thanks a lot!

@roywei
Copy link
Member Author

roywei commented Nov 15, 2018

closed in favor of #13284

@roywei roywei closed this Nov 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-response PR is reviewed and waiting for contributor to respond
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cpp-package] inception_bn.cpp is wrong
5 participants