NO-ISSUE: Fix failing 'CI :: License headers' check #2838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That was broken with merge of apache#2749
|
Hi @domhanak @treblereel @ricardozanini this is simple PR related to #2749. Do you have an idea why the 'CI :: License headers' was not started as part of it? I do not see a fail in the main PR view: I see fail just when I check commit history of the files, for example this one: |
|
@jomarko I think the check didn't start because the last commit of that PR was on 18 November, most likely the check wasn't present at that time. |
domhanak
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That was broken with merge of #2749