Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kie-issues#1592: Custom Item Definitions shows <Undefined> type on the new DMN Editor #2837

Merged
merged 1 commit into from
Jan 9, 2025
Merged

kie-issues#1592: Custom Item Definitions shows <Undefined> type on the new DMN Editor #2837

merged 1 commit into from
Jan 9, 2025

Conversation

Kusuma04-dev
Copy link
Contributor

closes apache/incubator-kie-issues#1592 Custom Item Definitions shows type on the new DMN Editor Data Types tab
Before fix:
Screenshot 2025-01-09 at 11 16 12 AM

After fix:
Uploading Screenshot 2025-01-09 at 11.16.35 AM.png…

jomarko
jomarko approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@jomarko jomarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. The fix works correctly from my point of view.

The failing 'CI :: License headers' is caused by #2749 and is not related to this PR.

@yesamer yesamer requested a review from ljmotta January 9, 2025 08:50
yesamer
yesamer approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@yesamer yesamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Kusuma04-dev

ljmotta
ljmotta approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@ljmotta ljmotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kusuma04-dev Thanks!

@tiagobento tiagobento changed the title Custom Item Definitions shows <Undefined> type on the new DMN Editor kie-issues#1592: Custom Item Definitions shows <Undefined> type on the new DMN Editor Jan 9, 2025
@yesamer
Copy link
Contributor

yesamer commented Jan 9, 2025

Merging, the failing 'CI :: License headers' is unrelated and already fixed.

@yesamer yesamer merged commit 8ce3224 into apache:main Jan 9, 2025
14 of 15 checks passed
@Kusuma04-dev Kusuma04-dev mentioned this pull request Jan 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbowers-ibm kbowers-ibm kbowers-ibm approved these changes

@ljmotta ljmotta ljmotta approved these changes

@yesamer yesamer yesamer approved these changes

@jomarko jomarko jomarko approved these changes

@tiagobento tiagobento Awaiting requested review from tiagobento tiagobento is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom Item Definitions shows <Undefined> type on the new DMN Editor Data Types tab
5 participants
@Kusuma04-dev @yesamer @jomarko @ljmotta @kbowers-ibm