Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #3483] Adding state duration summary #3485

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Conversation

fjtirado
Copy link
Contributor

@fjtirado fjtirado commented Apr 24, 2024

Fixes #3483
Add "kogito_node_instance_duration_milliseconds" distribution summary.
Different to the other two summaries, times are collected in milliseconds rather than seconds

@fjtirado fjtirado changed the title [Fix #3483] Adding state counter [Fix #3483] Adding state duration summary Apr 24, 2024
@fjtirado fjtirado force-pushed the Fix_#3483 branch 2 times, most recently from a6e8374 to 5a6fa6c Compare April 24, 2024 16:29
@fjtirado fjtirado requested review from elguardian and gmunozfe April 24, 2024 16:30
@elguardian
Copy link
Contributor

@fjtirado IMO we should record also the number this node has been executed. The reason is because you can calculate the mean (duration) / hits = average so we have an idea of the duration of the node....
min max would be interesting as well.

@fjtirado
Copy link
Contributor Author

fjtirado commented Apr 25, 2024

@fjtirado IMO we should record also the number this node has been executed. The reason is because you can calculate the mean (duration) / hits = average so we have an idea of the duration of the node.... min max would be interesting as well.

@elguardian I think this is automatically done by the Distribution summary micrometer. This is an example of what is sent to the elastic search for the proccess instances distribution summary
{"@timestamp":"2024-04-22T11:07:47.845Z","name":"kogito_process_instance_duration_seconds","type":"distribution_summary","app_id":"default-process-monitoring-listener","artifactId":"serverless-workflow-expression-quarkus","process_id":"division","version":"1.0-SNAPSHOT","count":1,"sum":0.061,"mean":0.061,"max":0.061}

@fjtirado fjtirado requested a review from nmirasch April 25, 2024 11:31
@fjtirado fjtirado merged commit 64b3242 into apache:main Apr 25, 2024
6 checks passed
rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add node duration metric to monitoring addon
3 participants