[Fix apache/incubator-kie-issues#987] New onError event #3428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjtirado
force-pushed
the
Fix_apache/incubator-kie-issues#987
branch
from
f853bcb to
1e84a09
Compare
fjtirado
force-pushed
the
Fix_apache/incubator-kie-issues#987
branch
from
1e84a09 to
283d96d
Compare
fjtirado
force-pushed
the
Fix_apache/incubator-kie-issues#987
branch
from
7296edb to
fde18f4
Compare
nmirasch
approved these changes
Mar 6, 2024
Although not strictly needed by the PR, for future additions, a new class in the hierarchy that holds the NodeInstance reference has been included. fields has been made final to remark that event objects are inmutable
wmedvede
approved these changes
Mar 6, 2024
|
@elguardian Good to know for the future. Which should be the naming convention in this case? |
|
@fjtirado ProcessErrorEvent as you are in Kie-api and belongs to the process error. |
rgdoliveira
pushed a commit
to rgdoliveira/kogito-runtimes
that referenced
this pull request
Mar 11, 2024
* [Fix apache/incubator-kie-issues#987] New onError event * [Fix apache/incubator-kie-issues#987] Adding unit test * [Fix apache/incubator-kie-issues#987] Refactor ProcessNodeEvent children Although not strictly needed by the PR, for future additions, a new class in the hierarchy that holds the NodeInstance reference has been included. fields has been made final to remark that event objects are inmutable
fjtirado
added a commit
to fjtirado/kogito-runtimes
that referenced
this pull request
Apr 3, 2024
* [Fix apache/incubator-kie-issues#987] New onError event * [Fix apache/incubator-kie-issues#987] Adding unit test * [Fix apache/incubator-kie-issues#987] Refactor ProcessNodeEvent children Although not strictly needed by the PR, for future additions, a new class in the hierarchy that holds the NodeInstance reference has been included. fields has been made final to remark that event objects are inmutable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes apache/incubator-kie-issues#987
Ensure that starting event is the first one and complete process events is the last one
Unlink error event from state event so, if there is an error is published always and not only if it happens in the sync part of the process.
Merge with apache/incubator-kie-drools#5766 and apache/incubator-kie-kogito-apps#2011