Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it easier to use JQ interpolation #3307

Closed
fjtirado opened this issue Dec 4, 2023 · 0 comments · Fixed by #3309
Closed

Make it easier to use JQ interpolation #3307

fjtirado opened this issue Dec 4, 2023 · 0 comments · Fixed by #3309
Assignees
@fjtirado

Comments

@fjtirado
Copy link
Contributor

fjtirado commented Dec 4, 2023 •
edited
Loading

Description

Right now to use JQ string interpolation in SWF you have to write

"description": "\"\\(.name) needs to be added to the JIRA developer team\""

Where as you can see there is a lot of escaping

It would be better to just write

"description": "\\(.name) needs to be added to the JIRA developer team"

Implementation ideas

Currently we are trying to evaluate if the string is an expression and if it is not assume hardcoded string. We can add an intermediate step to check if adding quotes to the string makes it an interpolated string expression.
@fjtirado fjtirado self-assigned this Dec 4, 2023
fjtirado added a commit to fjtirado/kogito-runtimes that referenced this issue Dec 4, 2023
@fjtirado
Fix apache#3307 - Easier string interpolation
0365db4 
As proposed in the issue description, remove the need for initial
quoutes in case of string interpolation
fjtirado added a commit to fjtirado/kogito-runtimes that referenced this issue Dec 4, 2023
@fjtirado
Fix apache#3307 - Easier string interpolation
ed4709a 
As proposed in the issue description, remove the need for initial
quoutes in case of string interpolation
fjtirado added a commit to fjtirado/kogito-runtimes that referenced this issue Dec 4, 2023
@fjtirado
Fix apache#3307 - Easier string interpolation
c47b55f 
As proposed in the issue description, remove the need for initial
quoutes in case of string interpolation
@fjtirado fjtirado mentioned this issue Dec 4, 2023
Merged
fjtirado added a commit to fjtirado/kogito-runtimes that referenced this issue Dec 4, 2023
@fjtirado
Fix apache#3307 - Easier string interpolation
e8e43bf 
As proposed in the issue description, remove the need for initial
quoutes in case of string interpolation
fjtirado added a commit that referenced this issue Dec 5, 2023
@fjtirado
Fix #3307 (#3309)
a5c4af1 
* Fix #3307 - Easier string interpolation

As proposed in the issue description, remove the need for initial
quoutes in case of string interpolation

* Alternative implementation using optional
@github-project-automation github-project-automation bot moved this from 📋 Backlog to 🎯 Done in 🦉 KIE Podling Board Dec 5, 2023
rgdoliveira pushed a commit to kiegroup/kogito-runtimes that referenced this issue Dec 13, 2023
@fjtirado @rgdoliveira
Fix apache#3307 (apache#3309)
12309ac 
* Fix apache#3307 - Easier string interpolation

As proposed in the issue description, remove the need for initial
quoutes in case of string interpolation

* Alternative implementation using optional
fjtirado added a commit to fjtirado/kogito-runtimes that referenced this issue Jan 10, 2024
@fjtirado
Fix apache#3307 (apache#3309)
52ab754 
* Fix apache#3307 - Easier string interpolation

As proposed in the issue description, remove the need for initial
quoutes in case of string interpolation

* Alternative implementation using optional
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fjtirado fjtirado

Labels
None yet
Projects
🦉 KIE Podling Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #3307 fjtirado/kogito-runtimes
1 participant
@fjtirado